瀏覽代碼

Firestore: Remove obsolete special case from tests when verifying "missing index" error message in non-default DB

Denver Coneybeare 2 年之前
父節點
當前提交
089f049be9

+ 5 - 9
Firestore/Example/Tests/Integration/API/FIRAggregateTests.mm

@@ -1119,15 +1119,11 @@
                                    "The NSError should have contained the word 'index' "
                                    "(case-insensitive), but got: %@",
                                    errorDescription);
-                     // TODO(b/316359394) Remove this check for the default databases once
-                     // cl/582465034 is rolled out to production.
-                     if ([[FSTIntegrationTestCase databaseID] isEqualToString:@"(default)"]) {
-                       XCTAssertTrue(
-                           [errorDescription containsString:@"https://console.firebase.google.com"],
-                           "The NSError should have contained the string "
-                           "'https://console.firebase.google.com', but got: %@",
-                           errorDescription);
-                     }
+                     XCTAssertTrue(
+                         [errorDescription containsString:@"https://console.firebase.google.com"],
+                         "The NSError should have contained the string "
+                         "'https://console.firebase.google.com', but got: %@",
+                         errorDescription);
                    }
                    XCTAssertNil(snapshot);
                    [queryCompletion fulfill];

+ 5 - 9
Firestore/Example/Tests/Integration/API/FIRCountTests.mm

@@ -249,15 +249,11 @@
                                    "The NSError should have contained the word 'index' "
                                    "(case-insensitive), but got: %@",
                                    errorDescription);
-                     // TODO(b/316359394) Remove this check for the default databases once
-                     // cl/582465034 is rolled out to production.
-                     if ([[FSTIntegrationTestCase databaseID] isEqualToString:@"(default)"]) {
-                       XCTAssertTrue(
-                           [errorDescription containsString:@"https://console.firebase.google.com"],
-                           "The NSError should have contained the string "
-                           "'https://console.firebase.google.com', but got: %@",
-                           errorDescription);
-                     }
+                     XCTAssertTrue(
+                         [errorDescription containsString:@"https://console.firebase.google.com"],
+                         "The NSError should have contained the string "
+                         "'https://console.firebase.google.com', but got: %@",
+                         errorDescription);
                    }
                    XCTAssertNil(snapshot);
                    [queryCompletion fulfill];