Address v9, resolved, and obsolete TODO's (#9659)

.github/workflows/functions.yml

@@ -109,8 +109,7 @@ jobs:
 
   functions-cron-only:
     # Don't run on private repo.
-# TODO: Uncomment below
-#    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
+    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
 
     runs-on: macos-11
     strategy:

.github/workflows/storage.yml

@@ -129,7 +129,7 @@ jobs:
 
   storage-cron-only:
     # Don't run on private repo.
-#    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
+    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
     runs-on: macos-11
     strategy:
       matrix:

.github/workflows/zip.yml

@@ -25,31 +25,30 @@ concurrency:
     cancel-in-progress: true
 
 jobs:
-  # TODO: Reenable package-release once v9 merges to master.
-  # package-release:
-  #   # Don't run on private repo.
-  #   if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
-  #   runs-on: macos-11
-  #   steps:
-  #   - uses: actions/checkout@v2
-  #   - uses: mikehardy/buildcache-action@50738c6c77de7f34e66b870e4f8ede333b69d077
-  #     with:
-  #       cache_key: ${{ matrix.os }}
-  #   - name: Xcode 13.2.1
-  #     run: sudo xcode-select -s /Applications/Xcode_13.2.1.app/Contents/Developer
-  #   - name: Setup Bundler
-  #     run: ./scripts/setup_bundler.sh
-  #   - name: ZipBuildingTest
-  #     run: |
-  #        mkdir -p release_zip_dir
-  #        sh -x scripts/build_zip.sh release_zip_dir \
-  #          "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git' }}"
-  #   - uses: actions/upload-artifact@v1
-  #     with:
-  #       name: Firebase-release-zip-zip
-  #       # Zip the entire output directory since the builder adds subdirectories we don't know the
-  #       # name of.
-  #       path: release_zip_dir
+  package-release:
+    # Don't run on private repo.
+    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
+    runs-on: macos-11
+    steps:
+    - uses: actions/checkout@v2
+    - uses: mikehardy/buildcache-action@50738c6c77de7f34e66b870e4f8ede333b69d077
+      with:
+        cache_key: ${{ matrix.os }}
+    - name: Xcode 13.2.1
+      run: sudo xcode-select -s /Applications/Xcode_13.2.1.app/Contents/Developer
+    - name: Setup Bundler
+      run: ./scripts/setup_bundler.sh
+    - name: ZipBuildingTest
+      run: |
+         mkdir -p release_zip_dir
+         sh -x scripts/build_zip.sh release_zip_dir \
+           "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git' }}"
+    - uses: actions/upload-artifact@v1
+      with:
+        name: Firebase-release-zip-zip
+        # Zip the entire output directory since the builder adds subdirectories we don't know the
+        # name of.
+        path: release_zip_dir
 
   build:
     # Don't run on private repo unless it is a PR.

Crashlytics/Protogen/nanopb/crashlytics.nanopb.c

@@ -54,7 +54,7 @@ const pb_field_t google_crashlytics_FilesPayload_File_fields[3] = {
 #if !defined(PB_FIELD_32BIT)
 /* If you get an error here, it means that you need to define PB_FIELD_32BIT
  * compile-time option. You can do that in pb.h or on compiler command line.
- * 
+ *
  * The reason you need to do this is that some of your messages contain tag
  * numbers or field sizes that are larger than what can fit in 8 or 16 bit
  * field descriptors.
@@ -65,7 +65,7 @@ PB_STATIC_ASSERT((pb_membersize(google_crashlytics_Report, apple_payload) < 6553
 #if !defined(PB_FIELD_16BIT) && !defined(PB_FIELD_32BIT)
 /* If you get an error here, it means that you need to define PB_FIELD_16BIT
  * compile-time option. You can do that in pb.h or on compiler command line.
- * 
+ *
  * The reason you need to do this is that some of your messages contain tag
  * numbers or field sizes that are larger than what can fit in the default
  * 8 bit descriptors.

FirebaseCore/Extension/FIRAppInternal.h

@@ -24,8 +24,6 @@
  * The internal interface to `FirebaseApp`. This is meant for first-party integrators, who need to
  * receive `FirebaseApp` notifications, log info about the success or failure of their
  * configuration, and access other internal functionality of `FirebaseApp`.
- *
- * TODO(b/28296561): Restructure this header.
  */
 NS_ASSUME_NONNULL_BEGIN
 

FirebaseDatabase/Sources/Api/FIRDatabase.m

@@ -97,7 +97,6 @@
 }
 
 + (NSString *)buildVersion {
-    // TODO: Restore git hash when build moves back to git
     return [NSString stringWithFormat:@"%@_%s", FIRFirebaseVersion(), __DATE__];
 }
 

FirebaseDynamicLinks/Sources/FIRDynamicLinks.m

@@ -557,9 +557,6 @@ static const NSInteger FIRErrorCodeDurableDeepLinkFailed = -119;
                                              errorDescription:(NSString *)errorDescription
                                               underlyingError:(nullable NSError *)underlyingError {
   self.retrievingPendingDynamicLink = NO;
-
-  // TODO (b/38035270) inform caller why we failed, for App developer it is hard to debug
-  // stuff like this without having source code access
 }
 
 #pragma mark - FIRDLRetrievalProcessDelegate
@@ -585,7 +582,6 @@ static const NSInteger FIRErrorCodeDurableDeepLinkFailed = -119;
 
 static NSString *kSelfDiagnoseOutputHeader =
     @"---- Firebase Dynamic Links diagnostic output start ----\n";
-// TODO (b/38397557) Add link to the "Debug FDL" documentation when docs is published
 static NSString *kSelfDiagnoseOutputFooter =
     @"---- Firebase Dynamic Links diagnostic output end ----\n";
 

scripts/check_whitespace.sh

@@ -25,24 +25,17 @@ options=(
   ' $'
 )
 
-# TODO(https://github.com/nanopb/nanopb/pull/622) remove Protogen exceptions
-# likely in a nanopb release after 0.3.9.7.
-
 git grep "${options[@]}" -- \
-    ':(exclude)Crashlytics/Protogen/nanopb' \
     ':(exclude)Crashlytics/ProtoSupport' \
     ':(exclude)Crashlytics/UnitTests/Data' \
-    ':(exclude)Firebase/CoreDiagnostics/FIRCDLibrary/Protogen/nanopb' \
     ':(exclude)Firebase/CoreDiagnostics/ProtoSupport' \
     ':(exclude)CoreOnly/NOTICES' \
     ':(exclude)Firebase/Firebase/NOTICES' \
     ':(exclude)Firebase/InAppMessaging/ProtoSupport' \
-    ':(exclude)Firebase/InAppMessaging/Analytics/Protogen/nanopb' \
     ':(exclude)Firestore/Protos/nanopb' \
     ':(exclude)Firestore/Protos/cpp' \
     ':(exclude)Firestore/Protos/objc' \
     ':(exclude)Firestore/third_party/abseil-cpp' \
-    ':(exclude)GoogleDataTransport/GDTCCTLibrary/Protogen/nanopb' \
     ':(exclude)GoogleDataTransport/ProtoSupport' \
     ':(exclude)ReleaseTooling/Template/NOTICES'