Browse Source

[v9] Reorganize `FirebaseCore*` modules (#9482)

* [skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`

* Reorganize FirebaseCore libraries for SPM and CP

* [skip ci] Revert "[skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`"

This reverts commit 2a837e39708c21b0a324743ab226bd6c01047de7.

* Review and fix CI

* Remove `heartbeat_logging.yml` and add `core_internal.yml`

* Remove trailing whitespace

* Fix more whitespace 😞

* Fix `core_internal.yml` scheme name

* Update `check_imports.swift` and TODO

* Review

* Add FirebaseCoreInternal pod to Firestore example's Podfile

* [skip ci] Review - remove TODOs

* [skip ci] Remove duplicate `XCTest` import
Nick Cooke 4 years ago
parent
commit
a09083f9d0
100 changed files with 238 additions and 121 deletions
  1. 0 1
      .github/workflows/core.yml
  2. 49 0
      .github/workflows/core_extension.yml
  3. 79 0
      .github/workflows/core_internal.yml
  4. 0 28
      .github/workflows/heartbeat_logging.yml
  5. 1 0
      CoreOnly/Tests/FirebasePodTest/Podfile
  6. 1 1
      Crashlytics/Crashlytics/DataCollection/FIRCLSDataCollectionArbiter.m
  7. 1 1
      Crashlytics/Crashlytics/FIRCrashlytics.m
  8. 1 1
      Crashlytics/Crashlytics/Helpers/FIRCLSLogger.m
  9. 1 1
      Crashlytics/Shared/FIRCLSConstants.m
  10. 1 1
      Crashlytics/UnitTests/FIRCLSConstantsTest.m
  11. 1 1
      Crashlytics/UnitTests/FIRCLSMetricKitManagerTests.m
  12. 1 1
      Crashlytics/UnitTests/FIRCLSReportManagerTests.m
  13. 1 1
      Crashlytics/UnitTests/Mocks/FIRAppFake.h
  14. 1 0
      Example/watchOSSample/Podfile
  15. 1 1
      FirebaseABTesting/Sources/ABTConditionalUserPropertyController.m
  16. 1 1
      FirebaseABTesting/Sources/ABTConstants.h
  17. 1 1
      FirebaseABTesting/Sources/FIRExperimentController.m
  18. 1 1
      FirebaseABTesting/Tests/Unit/ABTConditionalUserPropertyControllerTest.m
  19. 1 1
      FirebaseABTesting/Tests/Unit/FIRExperimentControllerTest.m
  20. 1 1
      FirebaseAppCheck/Sources/AppAttestProvider/FIRAppAttestProvider.m
  21. 1 1
      FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m
  22. 1 1
      FirebaseAppCheck/Sources/Core/FIRAppCheck.m
  23. 1 1
      FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h
  24. 1 1
      FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.m
  25. 1 1
      FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.m
  26. 1 1
      FirebaseAppCheck/Sources/Core/FIRAppCheckValidator.m
  27. 1 1
      FirebaseAppCheck/Sources/DebugProvider/API/FIRAppCheckDebugProviderAPIService.m
  28. 1 1
      FirebaseAppCheck/Sources/DebugProvider/FIRAppCheckDebugProvider.m
  29. 1 1
      FirebaseAppCheck/Sources/DeviceCheckProvider/API/FIRDeviceCheckAPIService.m
  30. 1 1
      FirebaseAppCheck/Sources/DeviceCheckProvider/FIRDeviceCheckProvider.m
  31. 1 1
      FirebaseAppCheck/Tests/Unit/AppAttestProvider/FIRAppAttestProviderTests.m
  32. 1 1
      FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckAPIServiceTests.m
  33. 1 1
      FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckIntegrationTests.m
  34. 1 1
      FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckSettingsTests.m
  35. 1 1
      FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckTests.m
  36. 1 1
      FirebaseAppCheck/Tests/Unit/DebugProvider/FIRAppCheckDebugProviderFactoryTests.m
  37. 1 1
      FirebaseAppCheck/Tests/Unit/DebugProvider/FIRAppCheckDebugProviderTests.m
  38. 1 1
      FirebaseAppCheck/Tests/Unit/DeviceCheckProvider/FIRDeviceCheckAPIServiceTests.m
  39. 1 1
      FirebaseAppCheck/Tests/Unit/DeviceCheckProvider/FIRDeviceCheckProviderTests.m
  40. 1 1
      FirebaseAppDistribution/Sources/FIRAppDistribution.m
  41. 1 1
      FirebaseAppDistribution/Sources/FIRAppDistributionUIService.m
  42. 1 1
      FirebaseAppDistribution/Sources/FIRFADApiService.m
  43. 1 1
      FirebaseAppDistribution/Sources/FIRFADLogger.m
  44. 1 1
      FirebaseAppDistribution/Tests/Unit/FIRAppDistributionMachOTests.m
  45. 1 1
      FirebaseAppDistribution/Tests/Unit/FIRAppDistributionTests.m
  46. 1 1
      FirebaseAppDistribution/Tests/Unit/FIRFADApiServiceTests.m
  47. 1 1
      FirebaseAuth/Sources/Auth/FIRAuth.m
  48. 1 1
      FirebaseAuth/Sources/Auth/FIRAuth_Internal.h
  49. 1 1
      FirebaseAuth/Sources/AuthProvider/OAuth/FIROAuthProvider.m
  50. 1 1
      FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m
  51. 1 1
      FirebaseAuth/Sources/Backend/FIRAuthBackend.m
  52. 1 1
      FirebaseAuth/Sources/Storage/FIRAuthKeychainServices.m
  53. 1 1
      FirebaseAuth/Sources/SystemService/FIRAuthAPNSTokenManager.m
  54. 1 1
      FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m
  55. 1 1
      FirebaseAuth/Sources/SystemService/FIRSecureTokenService.m
  56. 1 1
      FirebaseAuth/Sources/User/FIRUser.m
  57. 1 0
      FirebaseAuth/Tests/Sample/Podfile
  58. 1 1
      FirebaseAuth/Tests/Unit/FIRApp+FIRAuthUnitTests.h
  59. 1 1
      FirebaseAuth/Tests/Unit/FIRApp+FIRAuthUnitTests.m
  60. 1 1
      FirebaseAuth/Tests/Unit/FIRAuthLifeCycleTests.m
  61. 1 1
      FirebaseAuth/Tests/Unit/FIRAuthTests.m
  62. 1 1
      FirebaseAuth/Tests/Unit/FIROAuthProviderTests.m
  63. 1 1
      FirebaseAuth/Tests/Unit/FIRPhoneAuthProviderTests.m
  64. 1 1
      FirebaseCombineSwift/Tests/Unit/FirebaseCombine-unit-Bridging-Header.h
  65. 6 7
      FirebaseCore.podspec
  66. 0 0
      FirebaseCore/Extension/FIRAppInternal.h
  67. 0 0
      FirebaseCore/Extension/FIRComponent.h
  68. 0 0
      FirebaseCore/Extension/FIRComponentContainer.h
  69. 0 0
      FirebaseCore/Extension/FIRComponentType.h
  70. 0 0
      FirebaseCore/Extension/FIRCoreDiagnosticsConnector.h
  71. 0 0
      FirebaseCore/Extension/FIRDependency.h
  72. 0 0
      FirebaseCore/Extension/FIRHeartbeatInfo.h
  73. 0 0
      FirebaseCore/Extension/FIRHeartbeatLogger.h
  74. 0 0
      FirebaseCore/Extension/FIRLibrary.h
  75. 0 0
      FirebaseCore/Extension/FIRLogger.h
  76. 0 0
      FirebaseCore/Extension/FIROptionsInternal.h
  77. 0 0
      FirebaseCore/Extension/FirebaseCoreInternal.h
  78. 0 0
      FirebaseCore/Extension/dummy.m
  79. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/Heartbeat.swift
  80. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatController.swift
  81. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatStorage.swift
  82. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsBundle.swift
  83. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift
  84. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift
  85. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/Storage.swift
  86. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/StorageFactory.swift
  87. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/WeakContainer.swift
  88. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift
  89. 0 0
      FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift
  90. 30 0
      FirebaseCore/Internal/Tests/Common/Assertions.swift
  91. 1 1
      FirebaseCore/Internal/Tests/Integration/HeartbeatLoggingIntegrationTests.swift
  92. 1 14
      FirebaseCore/Internal/Tests/Unit/HeartbeatControllerTests.swift
  93. 1 2
      FirebaseCore/Internal/Tests/Unit/HeartbeatStorageTests.swift
  94. 1 1
      FirebaseCore/Internal/Tests/Unit/HeartbeatTests.swift
  95. 1 1
      FirebaseCore/Internal/Tests/Unit/HeartbeatsBundleTests.swift
  96. 1 1
      FirebaseCore/Internal/Tests/Unit/HeartbeatsPayloadTests.swift
  97. 1 1
      FirebaseCore/Internal/Tests/Unit/RingBufferTests.swift
  98. 1 1
      FirebaseCore/Internal/Tests/Unit/StorageTests.swift
  99. 1 1
      FirebaseCore/Internal/Tests/Unit/WeakContainerTests.swift
  100. 5 5
      FirebaseCore/Sources/FIRApp.m

+ 0 - 1
.github/workflows/core.yml

@@ -5,7 +5,6 @@ on:
     paths:
     - 'FirebaseCore**'
     - 'Interop/CoreDiagnostics/Public/*.h'
-    - 'HeartbeatLogging**'
     - '.github/workflows/core.yml'
     - 'Gemfile*'
   schedule:

+ 49 - 0
.github/workflows/core_extension.yml

@@ -0,0 +1,49 @@
+name: core_extension
+
+on:
+  pull_request:
+    paths:
+    - 'FirebaseCoreExtension.podspec'
+    - 'FirebaseCore/Extension/**'
+    - '.github/workflows/core_extension.yml'
+    - 'Gemfile*'
+  schedule:
+    # Run every day at 2am (PST) - cron uses UTC times
+    - cron:  '0 10 * * *'
+
+jobs:
+  # Since `FirebaseCoreExtension` only contains headers, linting is sufficient for testing.
+
+  pod-lib-lint:
+    # Don't run on private repo unless it is a PR.
+    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
+    runs-on: macos-11
+    strategy:
+      matrix:
+        target: [ios, tvos, macos]
+    env:
+      POD_LIB_LINT_ONLY: 1
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Bundler
+      run: scripts/setup_bundler.sh
+    - name: Build and test
+      run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseCoreExtension.podspec --platforms=${{ matrix.target }}
+
+  core-internal-cron-only:
+    # Don't run on private repo.
+    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
+    runs-on: macos-11
+    strategy:
+      matrix:
+        target: [ios, tvos, macos]
+        flags: [
+          '--use-static-frameworks'
+        ]
+    needs: pod-lib-lint
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Bundler
+      run: scripts/setup_bundler.sh
+    - name: PodLibLint CoreInternal Cron
+      run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseCoreExtension.podspec --platforms=${{ matrix.target }} ${{ matrix.flags }}

+ 79 - 0
.github/workflows/core_internal.yml

@@ -0,0 +1,79 @@
+name: core_internal
+
+on:
+  pull_request:
+    paths:
+    - 'FirebaseCoreInternal.podspec'
+    - 'FirebaseCore/Internal/**'
+    - '.github/workflows/core_internal.yml'
+    - 'Gemfile*'
+  schedule:
+    # Run every day at 2am (PST) - cron uses UTC times
+    - cron:  '0 10 * * *'
+
+jobs:
+  pod-lib-lint:
+    # Don't run on private repo unless it is a PR.
+    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
+    runs-on: macos-11
+    strategy:
+      matrix:
+        target: [ios, tvos, macos]
+    env:
+      POD_LIB_LINT_ONLY: 1
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Bundler
+      run: scripts/setup_bundler.sh
+    - name: Build and test
+      run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseCoreInternal.podspec --platforms=${{ matrix.target }}
+
+  spm:
+    # Don't run on private repo unless it is a PR.
+    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
+    runs-on: macos-11
+    strategy:
+      matrix:
+        target: [iOS, tvOS, macOS, catalyst, watchOS]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Initialize xcodebuild
+      run: scripts/setup_spm_tests.sh
+    - name: FirebaseCoreInternalTests
+      run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseCoreInternalTests ${{ matrix.target }} spm
+
+  catalyst:
+    # Don't run on private repo unless it is a PR.
+    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
+    runs-on: macos-11
+    env:
+      POD_LIB_LINT_ONLY: 1
+    steps:
+    - uses: actions/checkout@v2
+    - uses: mikehardy/buildcache-action@50738c6c77de7f34e66b870e4f8ede333b69d077
+      with:
+        cache_key: ${{ matrix.os }}
+    - name: Setup Bundler
+      run: scripts/setup_bundler.sh
+    - name: Setup Catalyst project and run unit tests
+      run: scripts/test_catalyst.sh FirebaseCoreInternal test FirebaseCoreInternal-Unit-Unit
+    - name: Setup Catalyst project and run integration tests
+      run: scripts/test_catalyst.sh FirebaseCoreInternal test FirebaseCoreInternal-Unit-Integration
+
+  core-internal-cron-only:
+    # Don't run on private repo.
+    if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
+    runs-on: macos-11
+    strategy:
+      matrix:
+        target: [ios, tvos, macos]
+        flags: [
+          '--use-static-frameworks'
+        ]
+    needs: pod-lib-lint
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Bundler
+      run: scripts/setup_bundler.sh
+    - name: PodLibLint CoreInternal Cron
+      run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseCoreInternal.podspec --platforms=${{ matrix.target }} ${{ matrix.flags }}

+ 0 - 28
.github/workflows/heartbeat_logging.yml

@@ -1,28 +0,0 @@
-name: heartbeat_logging
-
-on:
-  pull_request:
-    paths:
-    - 'HeartbeatLogging**'
-    - '.github/workflows/heartbeat_logging.yml'
-    - 'Gemfile*'
-
-  # TODO(nickcooke): Schedule cron job.
-
-jobs:
-
-  # TODO(nickcooke): Configure `CocoaPods` job(s).
-
-  spm:
-    # Don't run on private repo unless it is a PR.
-    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
-    runs-on: macos-11
-    strategy:
-      matrix:
-        target: [iOS, tvOS, macOS, catalyst, watchOS]
-    steps:
-    - uses: actions/checkout@v2
-    - name: Initialize xcodebuild
-      run: scripts/setup_spm_tests.sh
-    - name: HeartbeatLoggingTests
-      run: scripts/third_party/travis/retry.sh ./scripts/build.sh HeartbeatLoggingTests ${{ matrix.target }} spm

+ 1 - 0
CoreOnly/Tests/FirebasePodTest/Podfile

@@ -37,6 +37,7 @@ target 'FirebasePodTest' do
   pod 'FirebaseMessagingInterop', :path => '../../../'
   pod 'FirebaseCoreDiagnostics', :path => '../../../'
   pod 'FirebaseCoreInternal', :path => '../../../'
+  pod 'FirebaseCoreExtension', :path => '../../../'
 
   pod 'FirebaseAnalytics' # Analytics is not open source
 end

+ 1 - 1
Crashlytics/Crashlytics/DataCollection/FIRCLSDataCollectionArbiter.m

@@ -20,7 +20,7 @@
 #import "FBLPromises.h"
 #endif
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "Crashlytics/Crashlytics/FIRCLSUserDefaults/FIRCLSUserDefaults.h"
 

+ 1 - 1
Crashlytics/Crashlytics/FIRCrashlytics.m

@@ -46,7 +46,7 @@
 #import "Crashlytics/Crashlytics/Controllers/FIRCLSReportManager.h"
 #import "Crashlytics/Crashlytics/Controllers/FIRCLSReportUploader.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 #import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
 

+ 1 - 1
Crashlytics/Crashlytics/Helpers/FIRCLSLogger.m

@@ -14,7 +14,7 @@
 
 #import "Crashlytics/Crashlytics/Helpers/FIRCLSLogger.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 FIRLoggerService kFIRLoggerCrashlytics = @"[Firebase/Crashlytics]";
 

+ 1 - 1
Crashlytics/Shared/FIRCLSConstants.m

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 #import "Crashlytics/Shared/FIRCLSConstants.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #define STR_HELPER(x) #x
 #define STR(x) STR_HELPER(x)

+ 1 - 1
Crashlytics/UnitTests/FIRCLSConstantsTest.m

@@ -15,7 +15,7 @@
 #import <XCTest/XCTest.h>
 
 #import "Crashlytics/Shared/FIRCLSConstants.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #define STR_HELPER(x) #x
 #define STR(x) STR_HELPER(x)

+ 1 - 1
Crashlytics/UnitTests/FIRCLSMetricKitManagerTests.m

@@ -16,7 +16,7 @@
 #import <XCTest/XCTest.h>
 
 #import "Crashlytics/Crashlytics/Controllers/FIRCLSMetricKitManager.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #if CLS_METRICKIT_SUPPORTED
 

+ 1 - 1
Crashlytics/UnitTests/FIRCLSReportManagerTests.m

@@ -15,7 +15,7 @@
 #import <Foundation/Foundation.h>
 #import <XCTest/XCTest.h>
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #if __has_include(<FBLPromises/FBLPromises.h>)
 #import <FBLPromises/FBLPromises.h>

+ 1 - 1
Crashlytics/UnitTests/Mocks/FIRAppFake.h

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface FIRAppFake : NSObject
 

+ 1 - 0
Example/watchOSSample/Podfile

@@ -9,6 +9,7 @@ target 'SampleWatchAppWatchKitExtension' do
 
   pod 'FirebaseCore', :path => '../../'
   pod 'FirebaseMessaging', :path => '../../'
+  pod 'FirebaseCoreInternal', :path => '../../'
   pod 'FirebaseCoreDiagnostics', :path => '../../'
   pod 'FirebaseInstallations', :path => '../../'
   pod 'FirebaseStorage', :path => '../../'

+ 1 - 1
FirebaseABTesting/Sources/ABTConditionalUserPropertyController.m

@@ -16,7 +16,7 @@
 
 #import "FirebaseABTesting/Sources/ABTConstants.h"
 #import "FirebaseABTesting/Sources/Public/FirebaseABTesting/FIRLifecycleEvents.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
 
 @implementation ABTConditionalUserPropertyController {

+ 1 - 1
FirebaseABTesting/Sources/ABTConstants.h

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 #import <Foundation/Foundation.h>
-#import "FirebaseCore/Internal/FIRLogger.h"
+#import "FirebaseCore/Extension/FIRLogger.h"
 
 #define ABT_MSEC_PER_SEC 1000ull
 

+ 1 - 1
FirebaseABTesting/Sources/FIRExperimentController.m

@@ -18,7 +18,7 @@
 #import "FirebaseABTesting/Sources/ABTConstants.h"
 #import "FirebaseABTesting/Sources/Private/ABTExperimentPayload.h"
 #import "FirebaseABTesting/Sources/Public/FirebaseABTesting/FIRLifecycleEvents.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
 

+ 1 - 1
FirebaseABTesting/Tests/Unit/ABTConditionalUserPropertyControllerTest.m

@@ -23,7 +23,7 @@
 #import "FirebaseABTesting/Tests/Unit/ABTFakeFIRAConditionalUserPropertyController.h"
 #import "FirebaseABTesting/Tests/Unit/ABTTestUniversalConstants.h"
 #import "FirebaseABTesting/Tests/Unit/Utilities/ABTTestUtilities.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface ABTConditionalUserPropertyController (ExposedForTest)
 - (NSInteger)maxNumberOfExperimentsOfOrigin:(NSString *)origin;

+ 1 - 1
FirebaseABTesting/Tests/Unit/FIRExperimentControllerTest.m

@@ -23,7 +23,7 @@
 #import "FirebaseABTesting/Tests/Unit/ABTFakeFIRAConditionalUserPropertyController.h"
 #import "FirebaseABTesting/Tests/Unit/ABTTestUniversalConstants.h"
 #import "FirebaseABTesting/Tests/Unit/Utilities/ABTTestUtilities.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
 
 extern ABTExperimentPayload *ABTDeserializeExperimentPayload(NSData *payload);

+ 1 - 1
FirebaseAppCheck/Sources/AppAttestProvider/FIRAppAttestProvider.m

@@ -40,7 +40,7 @@
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.h"
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckHTTPError.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m

@@ -25,7 +25,7 @@
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.h"
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import <GoogleUtilities/GULURLSessionDataResponse.h>
 #import <GoogleUtilities/NSURLSession+GULPromises.h>

+ 1 - 1
FirebaseAppCheck/Sources/Core/FIRAppCheck.m

@@ -38,7 +38,7 @@
 #import "FirebaseAppCheck/Interop/FIRAppCheckInterop.h"
 #import "FirebaseAppCheck/Interop/FIRAppCheckTokenResultInterop.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h

@@ -16,7 +16,7 @@
 
 #import <Foundation/Foundation.h>
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 extern FIRLoggerService kFIRLoggerAppCheck;
 

+ 1 - 1
FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.m

@@ -16,7 +16,7 @@
 
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.m

@@ -16,7 +16,7 @@
 
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/Core/FIRAppCheckValidator.m

@@ -16,7 +16,7 @@
 
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckValidator.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @implementation FIRAppCheckValidator
 

+ 1 - 1
FirebaseAppCheck/Sources/DebugProvider/API/FIRAppCheckDebugProviderAPIService.m

@@ -31,7 +31,7 @@
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.h"
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/DebugProvider/FIRAppCheckDebugProvider.m

@@ -28,7 +28,7 @@
 #import "FirebaseAppCheck/Sources/DebugProvider/API/FIRAppCheckDebugProviderAPIService.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckToken.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/DeviceCheckProvider/API/FIRDeviceCheckAPIService.m

@@ -30,7 +30,7 @@
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.h"
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckLogger.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Sources/DeviceCheckProvider/FIRDeviceCheckProvider.m

@@ -36,7 +36,7 @@
 #import "FirebaseAppCheck/Sources/DeviceCheckProvider/DCDevice+FIRDeviceCheckTokenGenerator.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckToken.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/AppAttestProvider/FIRAppAttestProviderTests.m

@@ -33,7 +33,7 @@
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.h"
 #import "FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckHTTPError.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "SharedTestUtilities/AppCheckBackoffWrapperFake/FIRAppCheckBackoffWrapperFake.h"
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckAPIServiceTests.m

@@ -31,7 +31,7 @@
 #import "SharedTestUtilities/Date/FIRDateTestUtils.h"
 #import "SharedTestUtilities/URLSession/FIRURLSessionOCMockStub.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface FIRAppCheckAPIServiceTests : XCTestCase
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckIntegrationTests.m

@@ -28,7 +28,7 @@
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRDeviceCheckProvider.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRDeviceCheckProviderFactory.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckSettingsTests.m

@@ -20,7 +20,7 @@
 
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface FIRAppCheckSettingsTests : XCTestCase
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckTests.m

@@ -36,7 +36,7 @@
 #import "FirebaseAppCheck/Sources/Core/TokenRefresh/FIRAppCheckTokenRefreshResult.h"
 #import "FirebaseAppCheck/Sources/Core/TokenRefresh/FIRAppCheckTokenRefresher.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 // The FAC token value returned when an error occurs.
 static NSString *const kDummyToken = @"eyJlcnJvciI6IlVOS05PV05fRVJST1IifQ==";

+ 1 - 1
FirebaseAppCheck/Tests/Unit/DebugProvider/FIRAppCheckDebugProviderFactoryTests.m

@@ -19,7 +19,7 @@
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckDebugProvider.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckDebugProviderFactory.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface FIRAppCheckDebugProviderFactoryTests : XCTestCase
 @end

+ 1 - 1
FirebaseAppCheck/Tests/Unit/DebugProvider/FIRAppCheckDebugProviderTests.m

@@ -23,7 +23,7 @@
 #import "FirebaseAppCheck/Sources/DebugProvider/API/FIRAppCheckDebugProviderAPIService.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckDebugProvider.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 static NSString *const kDebugTokenEnvKey = @"FIRAAppCheckDebugToken";
 static NSString *const kDebugTokenUserDefaultsKey = @"FIRAAppCheckDebugToken";

+ 1 - 1
FirebaseAppCheck/Tests/Unit/DeviceCheckProvider/FIRDeviceCheckAPIServiceTests.m

@@ -30,7 +30,7 @@
 #import "FirebaseAppCheck/Tests/Unit/Utils/FIRFixtureLoader.h"
 #import "SharedTestUtilities/URLSession/FIRURLSessionOCMockStub.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 typedef BOOL (^FIRRequestValidationBlock)(NSURLRequest *request);
 

+ 1 - 1
FirebaseAppCheck/Tests/Unit/DeviceCheckProvider/FIRDeviceCheckProviderTests.m

@@ -24,7 +24,7 @@
 #import "FirebaseAppCheck/Sources/DeviceCheckProvider/FIRDeviceCheckTokenGenerator.h"
 #import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRDeviceCheckProvider.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "SharedTestUtilities/AppCheckBackoffWrapperFake/FIRAppCheckBackoffWrapperFake.h"
 

+ 1 - 1
FirebaseAppDistribution/Sources/FIRAppDistribution.m

@@ -15,7 +15,7 @@
 
 #import <GoogleUtilities/GULAppDelegateSwizzler.h>
 #import <GoogleUtilities/GULUserDefaults.h>
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 
 #import "FirebaseAppDistribution/Sources/FIRAppDistributionMachO.h"

+ 1 - 1
FirebaseAppDistribution/Sources/FIRAppDistributionUIService.m

@@ -15,7 +15,7 @@
 #import "FirebaseAppDistribution/Sources/FIRAppDistributionUIService.h"
 #import "FirebaseAppDistribution/Sources/FIRFADLogger.h"
 #import "FirebaseAppDistribution/Sources/Public/FirebaseAppDistribution/FIRAppDistribution.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import <AuthenticationServices/AuthenticationServices.h>
 #import <SafariServices/SafariServices.h>

+ 1 - 1
FirebaseAppDistribution/Sources/FIRFADApiService.m

@@ -14,7 +14,7 @@
 #import "FirebaseAppDistribution/Sources/FIRFADApiService.h"
 #import <Foundation/Foundation.h>
 #import "FirebaseAppDistribution/Sources/FIRFADLogger.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 
 NSString *const kFIRFADApiErrorDomain = @"com.firebase.appdistribution.api";

+ 1 - 1
FirebaseAppDistribution/Sources/FIRFADLogger.m

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 #import "FirebaseAppDistribution/Sources/FIRFADLogger.h"
-#import "FirebaseCore/Internal/FIRLogger.h"
+#import "FirebaseCore/Extension/FIRLogger.h"
 
 FIRLoggerService kFIRLoggerAppDistribution = @"[Firebase/AppDistribution]";
 

+ 1 - 1
FirebaseAppDistribution/Tests/Unit/FIRAppDistributionMachOTests.m

@@ -16,7 +16,7 @@
 #import <XCTest/XCTest.h>
 
 #import "FirebaseAppDistribution/Sources/FIRAppDistributionMachO.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 @interface FIRAppDistributionMachOTests : XCTestCase
 @end

+ 1 - 1
FirebaseAppDistribution/Tests/Unit/FIRAppDistributionTests.m

@@ -22,7 +22,7 @@
 #import "FirebaseAppDistribution/Sources/FIRAppDistributionUIService.h"
 #import "FirebaseAppDistribution/Sources/FIRFADApiService.h"
 #import "FirebaseAppDistribution/Sources/Private/FIRAppDistribution.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 
 @interface FIRAppDistributionTests : XCTestCase

+ 1 - 1
FirebaseAppDistribution/Tests/Unit/FIRFADApiServiceTests.m

@@ -18,7 +18,7 @@
 
 #import "FirebaseAppDistribution/Sources/FIRFADApiService.h"
 #import "FirebaseAppDistribution/Sources/FIRFADLogger.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 
 NSString *const kFakeErrorDomain = @"test.failure.domain";

+ 1 - 1
FirebaseAuth/Sources/Auth/FIRAuth.m

@@ -26,7 +26,7 @@
 #import <GoogleUtilities/GULAppEnvironmentUtil.h>
 #import <GoogleUtilities/GULSceneDelegateSwizzler.h>
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FirebaseAuth.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthDataResult_Internal.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuthDispatcher.h"

+ 1 - 1
FirebaseAuth/Sources/Auth/FIRAuth_Internal.h

@@ -17,7 +17,7 @@
 #import <Foundation/Foundation.h>
 #import "FirebaseAuth/Interop/FIRAuthInterop.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h"
-#import "FirebaseCore/Internal/FIRLogger.h"
+#import "FirebaseCore/Extension/FIRLogger.h"
 
 @class FIRAuthRequestConfiguration;
 @class FIRAuthURLPresenter;

+ 1 - 1
FirebaseAuth/Sources/AuthProvider/OAuth/FIROAuthProvider.m

@@ -18,7 +18,7 @@
 #include <CommonCrypto/CommonCrypto.h>
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRFacebookAuthProvider.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIROAuthCredential.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m

@@ -20,7 +20,7 @@
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthSettings.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRMultiFactorResolver.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRPhoneAuthProvider.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseAuth/Sources/Backend/FIRAuthBackend.m

@@ -62,7 +62,7 @@
 #import "FirebaseAuth/Sources/Backend/RPC/FIRVerifyPhoneNumberRequest.h"
 #import "FirebaseAuth/Sources/Backend/RPC/FIRVerifyPhoneNumberResponse.h"
 #import "FirebaseAuth/Sources/Utilities/FIRAuthErrorUtils.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #if TARGET_OS_IOS
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRPhoneAuthProvider.h"

+ 1 - 1
FirebaseAuth/Sources/Storage/FIRAuthKeychainServices.m

@@ -18,7 +18,7 @@
 
 #import <Security/Security.h>
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"
 #import "FirebaseAuth/Sources/Storage/FIRAuthUserDefaults.h"

+ 1 - 1
FirebaseAuth/Sources/SystemService/FIRAuthAPNSTokenManager.m

@@ -18,7 +18,7 @@
 #if !TARGET_OS_OSX && !TARGET_OS_WATCH
 
 #import <GoogleUtilities/GULAppEnvironmentUtil.h>
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m

@@ -17,7 +17,7 @@
 #import <TargetConditionals.h>
 #if !TARGET_OS_OSX && !TARGET_OS_WATCH
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseAuth/Sources/SystemService/FIRSecureTokenService.m

@@ -26,7 +26,7 @@
 #import "FirebaseAuth/Sources/Backend/RPC/FIRSecureTokenRequest.h"
 #import "FirebaseAuth/Sources/Backend/RPC/FIRSecureTokenResponse.h"
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 NS_ASSUME_NONNULL_BEGIN
 

+ 1 - 1
FirebaseAuth/Sources/User/FIRUser.m

@@ -17,7 +17,7 @@
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIREmailAuthProvider.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRFederatedAuthProvider.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthDataResult_Internal.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"

+ 1 - 0
FirebaseAuth/Tests/Sample/Podfile

@@ -12,6 +12,7 @@ target 'AuthSample' do
   platform :ios, '10.0'
   pod 'FirebaseCore', :path => '../../../'
   pod 'FirebaseCoreDiagnostics', :path => '../../../'
+  pod 'FirebaseCoreInternal', :path => '../../../'
   pod 'FirebaseAuth', :path => '../../../', :testspecs => ['unit']
   pod 'FirebaseInstallations', :path => '../../..'
   pod 'FBSDKLoginKit'

+ 1 - 1
FirebaseAuth/Tests/Unit/FIRApp+FIRAuthUnitTests.h

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 /** @category FIRApp (FIRAuthUnitTests)
     @brief Tests for @c FIRAuth.

+ 1 - 1
FirebaseAuth/Tests/Unit/FIRApp+FIRAuthUnitTests.m

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Tests/Unit/FIRApp+FIRAuthUnitTests.h"
 

+ 1 - 1
FirebaseAuth/Tests/Unit/FIRAuthLifeCycleTests.m

@@ -17,7 +17,7 @@
 #import <XCTest/XCTest.h>
 
 #import "FirebaseAuth/Interop/FIRAuthInterop.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"
 #import "FirebaseAuth/Sources/Backend/FIRAuthRequestConfiguration.h"

+ 1 - 1
FirebaseAuth/Tests/Unit/FIRAuthTests.m

@@ -27,7 +27,7 @@
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRFacebookAuthProvider.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRGoogleAuthProvider.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIROAuthProvider.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthDispatcher.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"

+ 1 - 1
FirebaseAuth/Tests/Unit/FIROAuthProviderTests.m

@@ -23,7 +23,7 @@
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthErrors.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthUIDelegate.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIROAuthProvider.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseAuth/Tests/Unit/FIRPhoneAuthProviderTests.m

@@ -24,7 +24,7 @@
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthSettings.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthUIDelegate.h"
 #import "FirebaseAuth/Sources/Public/FirebaseAuth/FIRPhoneAuthProvider.h"
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 #import "FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.h"
 #import "FirebaseAuth/Sources/Auth/FIRAuth_Internal.h"

+ 1 - 1
FirebaseCombineSwift/Tests/Unit/FirebaseCombine-unit-Bridging-Header.h

@@ -19,7 +19,7 @@
 #import "FirebaseStorage/Sources/FIRStorageComponent.h"
 
 // Firebase Core
-#import "FirebaseCore/Internal/FirebaseCoreInternal.h"
+#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 
 // Firebase Auth
 #import <FirebaseAuth/FIRAuth.h>

+ 6 - 7
FirebaseCore.podspec

@@ -33,18 +33,17 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
 
   s.source_files = [
     'FirebaseCore/Sources/**/*.[mh]',
-    'FirebaseCore/Internal/*.h',
-    'Interop/CoreDiagnostics/Public/*.h',
-    'HeartbeatLogging/Sources/**/*.swift',
+    'FirebaseCore/Extension/*.h',
+    'Interop/CoreDiagnostics/Public/*.h'
   ]
 
   s.swift_version = '5.3'
 
   s.public_header_files = [
     'FirebaseCore/Sources/Public/FirebaseCore/*.h',
-    'FirebaseCore/Internal/*.h',
+    'FirebaseCore/Extension/*.h',
   ]
-  s.private_header_files = 'FirebaseCore/Internal/*.h'
+  s.private_header_files = 'FirebaseCore/Extension/*.h'
 
   s.framework = 'Foundation'
   s.ios.framework = 'UIKit'
@@ -54,8 +53,8 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
   # Remember to also update version in `cmake/external/GoogleUtilities.cmake`
   s.dependency 'GoogleUtilities/Environment', '~> 7.7'
   s.dependency 'GoogleUtilities/Logger', '~> 7.7'
-  s.dependency 'GoogleUtilities/NSData+zlib', '~> 7.7'
   s.dependency 'FirebaseCoreDiagnostics', '~> 8.0'
+  s.dependency 'FirebaseCoreInternal', '~> 8.12'
 
   s.pod_target_xcconfig = {
     'GCC_C_LANGUAGE_STANDARD' => 'c99',
@@ -71,7 +70,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
       unit_tests.scheme = { :code_coverage => true }
       unit_tests.platforms = {
         :ios => ios_deployment_target,
-        :osx => osx_deployment_target,
+        :osx => '10.15',
         :tvos => tvos_deployment_target
       }
       unit_tests.source_files = [

+ 0 - 0
FirebaseCore/Internal/FIRAppInternal.h → FirebaseCore/Extension/FIRAppInternal.h


+ 0 - 0
FirebaseCore/Internal/FIRComponent.h → FirebaseCore/Extension/FIRComponent.h


+ 0 - 0
FirebaseCore/Internal/FIRComponentContainer.h → FirebaseCore/Extension/FIRComponentContainer.h


+ 0 - 0
FirebaseCore/Internal/FIRComponentType.h → FirebaseCore/Extension/FIRComponentType.h


+ 0 - 0
FirebaseCore/Internal/FIRCoreDiagnosticsConnector.h → FirebaseCore/Extension/FIRCoreDiagnosticsConnector.h


+ 0 - 0
FirebaseCore/Internal/FIRDependency.h → FirebaseCore/Extension/FIRDependency.h


+ 0 - 0
FirebaseCore/Internal/FIRHeartbeatInfo.h → FirebaseCore/Extension/FIRHeartbeatInfo.h


+ 0 - 0
FirebaseCore/Internal/FIRHeartbeatLogger.h → FirebaseCore/Extension/FIRHeartbeatLogger.h


+ 0 - 0
FirebaseCore/Internal/FIRLibrary.h → FirebaseCore/Extension/FIRLibrary.h


+ 0 - 0
FirebaseCore/Internal/FIRLogger.h → FirebaseCore/Extension/FIRLogger.h


+ 0 - 0
FirebaseCore/Internal/FIROptionsInternal.h → FirebaseCore/Extension/FIROptionsInternal.h


+ 0 - 0
FirebaseCore/Internal/FirebaseCoreInternal.h → FirebaseCore/Extension/FirebaseCoreInternal.h


+ 0 - 0
FirebaseCore/Internal/dummy.m → FirebaseCore/Extension/dummy.m


+ 0 - 0
HeartbeatLogging/Sources/Heartbeat.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/Heartbeat.swift


+ 0 - 0
HeartbeatLogging/Sources/HeartbeatController.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatController.swift


+ 0 - 0
HeartbeatLogging/Sources/HeartbeatStorage.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatStorage.swift


+ 0 - 0
HeartbeatLogging/Sources/HeartbeatsBundle.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsBundle.swift


+ 0 - 0
HeartbeatLogging/Sources/HeartbeatsPayload.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift


+ 0 - 0
HeartbeatLogging/Sources/RingBuffer.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift


+ 0 - 0
HeartbeatLogging/Sources/Storage.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/Storage.swift


+ 0 - 0
HeartbeatLogging/Sources/StorageFactory.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/StorageFactory.swift


+ 0 - 0
HeartbeatLogging/Sources/WeakContainer.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/WeakContainer.swift


+ 0 - 0
HeartbeatLogging/Sources/_ObjC_HeartbeatController.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift


+ 0 - 0
HeartbeatLogging/Sources/_ObjC_HeartbeatsPayload.swift → FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift


+ 30 - 0
FirebaseCore/Internal/Tests/Common/Assertions.swift

@@ -0,0 +1,30 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import XCTest
+@testable import FirebaseCoreInternal
+import HeartbeatLoggingTestUtils
+
+// MARK: - Assertions
+
+func assertHeartbeatControllerFlushesEmptyPayload(_ controller: HeartbeatController) {
+  XCTAssertEqual(
+    controller.flushHeartbeatFromToday().headerValue(),
+    HeartbeatsPayload.emptyPayload.headerValue()
+  )
+  XCTAssertEqual(
+    controller.flush().headerValue(),
+    HeartbeatsPayload.emptyPayload.headerValue()
+  )
+}

+ 1 - 1
HeartbeatLogging/Tests/Integration/HeartbeatLoggingIntegrationTests.swift → FirebaseCore/Internal/Tests/Integration/HeartbeatLoggingIntegrationTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 import HeartbeatLoggingTestUtils
 
 class HeartbeatLoggingIntegrationTests: XCTestCase {

+ 1 - 14
HeartbeatLogging/Tests/Unit/HeartbeatControllerTests.swift → FirebaseCore/Internal/Tests/Unit/HeartbeatControllerTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 import HeartbeatLoggingTestUtils
 
 class HeartbeatControllerTests: XCTestCase {
@@ -406,16 +406,3 @@ private class HeartbeatStorageFake: HeartbeatStorageProtocol {
     return oldHeartbeatsBundle
   }
 }
-
-// MARK: - Assertions
-
-func assertHeartbeatControllerFlushesEmptyPayload(_ controller: HeartbeatController) {
-  XCTAssertEqual(
-    controller.flushHeartbeatFromToday().headerValue(),
-    HeartbeatsPayload.emptyPayload.headerValue()
-  )
-  XCTAssertEqual(
-    controller.flush().headerValue(),
-    HeartbeatsPayload.emptyPayload.headerValue()
-  )
-}

+ 1 - 2
HeartbeatLogging/Tests/Unit/HeartbeatStorageTests.swift → FirebaseCore/Internal/Tests/Unit/HeartbeatStorageTests.swift

@@ -13,8 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
-
+@testable import FirebaseCoreInternal
 class HeartbeatStorageTests: XCTestCase {
   // MARK: - Instance Management
 

+ 1 - 1
HeartbeatLogging/Tests/Unit/HeartbeatTests.swift → FirebaseCore/Internal/Tests/Unit/HeartbeatTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 
 class TimePeriodTests: XCTestCase {
   override func setUpWithError() throws {

+ 1 - 1
HeartbeatLogging/Tests/Unit/HeartbeatsBundleTests.swift → FirebaseCore/Internal/Tests/Unit/HeartbeatsBundleTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 import HeartbeatLoggingTestUtils
 
 class HeartbeatsBundleTests: XCTestCase {

+ 1 - 1
HeartbeatLogging/Tests/Unit/HeartbeatsPayloadTests.swift → FirebaseCore/Internal/Tests/Unit/HeartbeatsPayloadTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 import HeartbeatLoggingTestUtils
 
 class HeartbeatsPayloadTests: XCTestCase {

+ 1 - 1
HeartbeatLogging/Tests/Unit/RingBufferTests.swift → FirebaseCore/Internal/Tests/Unit/RingBufferTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 
 class RingBufferTests: XCTestCase {
   // `RingBuffer` is a generic type. `String` is used for simplified testing.

+ 1 - 1
HeartbeatLogging/Tests/Unit/StorageTests.swift → FirebaseCore/Internal/Tests/Unit/StorageTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 
 private enum Constants {
   static let testData = "test_data".data(using: .utf8)!

+ 1 - 1
HeartbeatLogging/Tests/Unit/WeakContainerTests.swift → FirebaseCore/Internal/Tests/Unit/WeakContainerTests.swift

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import XCTest
-@testable import HeartbeatLogging
+@testable import FirebaseCoreInternal
 
 class WeakContainerTests: XCTestCase {
   func testContainersObjectIsWeaklyRetained() throws {

+ 5 - 5
FirebaseCore/Sources/FIRApp.m

@@ -30,11 +30,11 @@
 #import "FirebaseCore/Sources/FIRConfigurationInternal.h"
 #import "FirebaseCore/Sources/FIRFirebaseUserAgent.h"
 
-#import "FirebaseCore/Internal/FIRAppInternal.h"
-#import "FirebaseCore/Internal/FIRCoreDiagnosticsConnector.h"
-#import "FirebaseCore/Internal/FIRLibrary.h"
-#import "FirebaseCore/Internal/FIRLogger.h"
-#import "FirebaseCore/Internal/FIROptionsInternal.h"
+#import "FirebaseCore/Extension/FIRAppInternal.h"
+#import "FirebaseCore/Extension/FIRCoreDiagnosticsConnector.h"
+#import "FirebaseCore/Extension/FIRLibrary.h"
+#import "FirebaseCore/Extension/FIRLogger.h"
+#import "FirebaseCore/Extension/FIROptionsInternal.h"
 #import "FirebaseCore/Sources/Public/FirebaseCore/FIRVersion.h"
 
 #import <GoogleUtilities/GULAppEnvironmentUtil.h>

Some files were not shown because too many files changed in this diff