Kaynağa Gözat

[Sessions] Migrate to import access modifiers (#14670)

Nick Cooke 11 ay önce
ebeveyn
işleme
cb10f051c5

+ 5 - 6
.github/workflows/sessions.yml

@@ -26,7 +26,7 @@ jobs:
         target: [ios, tvos, macos, watchos]
         build-env:
           - os: macos-14
-            xcode: Xcode_15.3
+            xcode: Xcode_16.2
             tests:
           # Flaky tests on CI
           - os: macos-15
@@ -51,11 +51,13 @@ jobs:
   spm-package-resolved:
     env:
       FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1
-    runs-on: macos-14
+    runs-on: macos-15
     outputs:
       cache_key: ${{ steps.generate_cache_key.outputs.cache_key }}
     steps:
       - uses: actions/checkout@v4
+      - name: Xcode
+        run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
       - name: Generate Swift Package.resolved
         id: swift_package_resolve
         run: |
@@ -78,11 +80,8 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: macos-13
-            xcode: Xcode_15.2
-            target: iOS
           - os: macos-14
-            xcode: Xcode_15.4
+            xcode: Xcode_16.2
             target: iOS
           - os: macos-15
             xcode: Xcode_16.2

+ 3 - 3
FirebaseSessions/Sources/ApplicationInfo.swift

@@ -15,16 +15,16 @@
 
 import Foundation
 
-@_implementationOnly import FirebaseCore
+internal import FirebaseCore
 
 #if SWIFT_PACKAGE
   import FirebaseSessionsObjC
 #endif // SWIFT_PACKAGE
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// Development environment for the application.

+ 1 - 1
FirebaseSessions/Sources/EventGDTLogger.swift

@@ -15,7 +15,7 @@
 
 import Foundation
 
-@_implementationOnly import GoogleDataTransport
+internal import GoogleDataTransport
 
 protocol EventGDTLoggerProtocol {
   func logEvent(event: SessionStartEvent, completion: @escaping (Result<Void, Error>) -> Void)

+ 4 - 4
FirebaseSessions/Sources/FirebaseSessions.swift

@@ -15,16 +15,16 @@
 import Foundation
 
 // Avoids exposing internal FirebaseCore APIs to Swift users.
-@_implementationOnly import FirebaseCoreExtension
-@_implementationOnly import FirebaseInstallations
-@_implementationOnly import GoogleDataTransport
+internal import FirebaseCoreExtension
+internal import FirebaseInstallations
+internal import GoogleDataTransport
 
 #if swift(>=6.0)
   internal import Promises
 #elseif swift(>=5.10)
   import Promises
 #else
-  @_implementationOnly import Promises
+  internal import Promises
 #endif
 
 private enum GoogleDataTransportConfig {

+ 1 - 1
FirebaseSessions/Sources/GoogleDataTransport+GoogleDataTransportProtocol.swift

@@ -15,7 +15,7 @@
 
 import Foundation
 
-@_implementationOnly import GoogleDataTransport
+internal import GoogleDataTransport
 
 enum GoogleDataTransportProtocolErrors: Error {
   case writeFailure

+ 1 - 1
FirebaseSessions/Sources/Installations+InstallationsProtocol.swift

@@ -15,7 +15,7 @@
 
 import Foundation
 
-@_implementationOnly import FirebaseInstallations
+internal import FirebaseInstallations
 
 protocol InstallationsProtocol {
   var installationsWaitTimeInSecond: Int { get }

+ 1 - 1
FirebaseSessions/Sources/Logger.swift

@@ -15,7 +15,7 @@
 
 import Foundation
 
-@_implementationOnly import FirebaseCoreExtension
+internal import FirebaseCoreExtension
 
 ///
 /// Logger is responsible for printing console logs

+ 2 - 2
FirebaseSessions/Sources/NetworkInfo.swift

@@ -20,9 +20,9 @@ import Foundation
 #endif // SWIFT_PACKAGE
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 protocol NetworkInfoProtocol {

+ 1 - 1
FirebaseSessions/Sources/SessionGenerator.swift

@@ -15,7 +15,7 @@
 
 import Foundation
 
-@_implementationOnly import FirebaseInstallations
+internal import FirebaseInstallations
 
 struct SessionInfo {
   let sessionId: String

+ 3 - 3
FirebaseSessions/Sources/SessionStartEvent.swift

@@ -15,16 +15,16 @@
 
 import Foundation
 
-@_implementationOnly import GoogleDataTransport
+internal import GoogleDataTransport
 
 #if SWIFT_PACKAGE
   import FirebaseSessionsObjC
 #endif // SWIFT_PACKAGE
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 ///

+ 2 - 2
FirebaseSessions/Sources/Settings/SettingsCacheClient.swift

@@ -16,9 +16,9 @@
 import Foundation
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_UserDefaults
+  internal import GoogleUtilities_UserDefaults
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// CacheKey is like a "key" to a "safe". It provides necessary metadata about the current cache to

+ 2 - 2
FirebaseSessions/Sources/Settings/SettingsDownloadClient.swift

@@ -16,9 +16,9 @@
 import Foundation
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 protocol SettingsDownloadClient {

+ 1 - 1
FirebaseSessions/Tests/TestApp/Shared/MockSubscriberSDK.swift

@@ -17,7 +17,7 @@ import FirebaseSessions
 import Foundation
 
 // Avoids exposing internal FirebaseCore APIs to Swift users.
-@_implementationOnly import FirebaseCoreExtension
+internal import FirebaseCoreExtension
 
 @objc(FIRMockSubscriberSDKProtocol)
 protocol MockSubscriberSDKProtocol {

+ 2 - 2
FirebaseSessions/Tests/Unit/Mocks/MockApplicationInfo.swift

@@ -16,9 +16,9 @@
 import Foundation
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 @testable import FirebaseSessions

+ 1 - 1
FirebaseSessions/Tests/Unit/Mocks/MockInstallationsProtocol.swift

@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-@_implementationOnly import FirebaseInstallations
+internal import FirebaseInstallations
 
 @testable import FirebaseSessions
 

+ 2 - 2
FirebaseSessions/Tests/Unit/Mocks/MockNetworkInfo.swift

@@ -16,9 +16,9 @@
 import Foundation
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 @testable import FirebaseSessions

+ 2 - 2
FirebaseSessions/Tests/Unit/SessionStartEventTests.swift

@@ -20,9 +20,9 @@ import XCTest
 #endif // SWIFT_PACKAGE
 
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_Environment
+  internal import GoogleUtilities_Environment
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 @testable import FirebaseSessions