check_imports.swift 7.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207
  1. #!/usr/bin/swift
  2. /*
  3. * Copyright 2020 Google LLC
  4. *
  5. * Licensed under the Apache License, Version 2.0 (the "License");
  6. * you may not use this file except in compliance with the License.
  7. * You may obtain a copy of the License at
  8. *
  9. * http://www.apache.org/licenses/LICENSE-2.0
  10. *
  11. * Unless required by applicable law or agreed to in writing, software
  12. * distributed under the License is distributed on an "AS IS" BASIS,
  13. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  14. * See the License for the specific language governing permissions and
  15. * limitations under the License.
  16. */
  17. // Utility script for verifying `import` and `include` syntax. This ensures a
  18. // consistent style as well as functionality across multiple package managers.
  19. // For more context, see https://github.com/firebase/firebase-ios-sdk/blob/master/HeadersImports.md.
  20. import Foundation
  21. // Skip these directories. Imports should only be repo-relative in libraries
  22. // and unit tests.
  23. let skipDirPatterns = ["/Sample/", "/Pods/", "FirebaseStorage/Tests/Integration",
  24. "FirebaseDynamicLinks/Tests/Integration",
  25. "FirebaseInAppMessaging/Tests/Integration/",
  26. "Example/InstanceID/App", "SymbolCollisionTest/", "/gen/",
  27. "CocoapodsIntegrationTest/", "FirebasePerformance/Tests/TestApp/",
  28. "FirebasePerformance/Tests/FIRPerfE2E/"] +
  29. [
  30. "CoreOnly/Sources", // Skip Firebase.h.
  31. "SwiftPMTests", // The SwiftPM imports test module imports.
  32. ] +
  33. // The following are temporary skips pending working through a first pass of the repo:
  34. [
  35. "FirebaseAppDistribution",
  36. "FirebaseCore/Sources/Private", // TODO: work through adding this back.
  37. "Firebase/CoreDiagnostics",
  38. "FirebaseDatabase/Sources/third_party/Wrap-leveldb", // Pending SwiftPM for leveldb.
  39. "Example",
  40. "FirebaseInstallations/Source/Tests/Unit/",
  41. "Firestore",
  42. "GoogleUtilitiesComponents",
  43. "FirebasePerformance/ProtoSupport/",
  44. ]
  45. // Skip existence test for patterns that start with the following:
  46. let skipImportPatterns = [
  47. "FBLPromise",
  48. "OCMock",
  49. "OCMStubRecorder",
  50. ]
  51. private class ErrorLogger {
  52. var foundError = false
  53. func log(_ message: String) {
  54. print(message)
  55. foundError = true
  56. }
  57. func importLog(_ message: String, _ file: String, _ line: Int) {
  58. log("Import Error: \(file):\(line) \(message)")
  59. }
  60. }
  61. private func checkFile(_ file: String, logger: ErrorLogger, inRepo repoURL: URL) {
  62. var fileContents = ""
  63. do {
  64. fileContents = try String(contentsOfFile: file, encoding: .utf8)
  65. } catch {
  66. logger.log("Could not read \(file). \(error)")
  67. // Not a source file, give up and return.
  68. return
  69. }
  70. let isPublic = file.range(of: "/Public/") != nil &&
  71. // TODO: Skip legacy GDTCCTLibrary file that isn't Public and should be moved.
  72. file.range(of: "GDTCCTLibrary/Public/GDTCOREvent+GDTCCTSupport.h") == nil
  73. let isPrivate = file.range(of: "/Sources/Private/") != nil ||
  74. // Delete when FirebaseInstallations fixes directory structure.
  75. file.range(of: "Source/Library/Private/FirebaseInstallationsInternal.h") != nil ||
  76. file.range(of: "GDTCORLibrary/Internal/GoogleDataTransportInternal.h") != nil
  77. // Treat all files with names finishing on "Test" or "Tests" as files with tests.
  78. let isTestFile = file.contains("Test.m") || file.contains("Tests.m") ||
  79. file.contains("Test.swift") || file.contains("Tests.swift")
  80. let isBridgingHeader = file.contains("Bridging-Header.h")
  81. var inSwiftPackage = false
  82. var inSwiftPackageElse = false
  83. let lines = fileContents.components(separatedBy: .newlines)
  84. var lineNum = 0
  85. nextLine: for rawLine in lines {
  86. let line = rawLine.trimmingCharacters(in: .whitespaces)
  87. lineNum += 1
  88. if line.starts(with: "#if SWIFT_PACKAGE") {
  89. inSwiftPackage = true
  90. } else if inSwiftPackage, line.starts(with: "#else") {
  91. inSwiftPackage = false
  92. inSwiftPackageElse = true
  93. } else if inSwiftPackageElse, line.starts(with: "#endif") {
  94. inSwiftPackageElse = false
  95. } else if inSwiftPackage {
  96. continue
  97. } else if line.starts(with: "@import") {
  98. // "@import" is only allowed for Swift Package Manager.
  99. logger.importLog("@import should not be used in CocoaPods library code", file, lineNum)
  100. }
  101. // "The #else of a SWIFT_PACKAGE check should only do CocoaPods module-style imports."
  102. if line.starts(with: "#import") || line.starts(with: "#include") {
  103. let importFile = line.components(separatedBy: " ")[1]
  104. if inSwiftPackageElse {
  105. if importFile.first != "<" {
  106. logger
  107. .importLog("Import in SWIFT_PACKAGE #else should start with \"<\".", file, lineNum)
  108. }
  109. continue
  110. }
  111. let importFileRaw = importFile.replacingOccurrences(of: "\"", with: "")
  112. .replacingOccurrences(of: "<", with: "")
  113. .replacingOccurrences(of: ">", with: "")
  114. if importFile.first == "\"" {
  115. // Public Headers should only use simple file names without paths.
  116. if isPublic {
  117. if importFile.contains("/") {
  118. logger.importLog("Public header import should not include \"/\"", file, lineNum)
  119. }
  120. } else if !FileManager.default.fileExists(atPath: repoURL.path + "/" + importFileRaw) {
  121. // Non-public header imports should be repo-relative paths. Unqualified imports are
  122. // allowed in private headers.
  123. if !isPrivate || importFile.contains("/") {
  124. for skip in skipImportPatterns {
  125. if importFileRaw.starts(with: skip) {
  126. continue nextLine
  127. }
  128. }
  129. logger.importLog("Import \(importFileRaw) does not exist.", file, lineNum)
  130. }
  131. }
  132. } else if importFile.first == "<", !isPrivate, !isTestFile, !isBridgingHeader {
  133. // Verify that double quotes are always used for intra-module imports.
  134. if importFileRaw.starts(with: "Firebase") {
  135. logger
  136. .importLog("Imports internal to the repo should use double quotes not \"<\"", file,
  137. lineNum)
  138. }
  139. }
  140. }
  141. }
  142. }
  143. private func main() -> Int32 {
  144. let logger = ErrorLogger()
  145. // Search the path upwards to find the root of the firebase-ios-sdk repo.
  146. var url = URL(fileURLWithPath: FileManager().currentDirectoryPath)
  147. while url.path != "/" {
  148. let script = url.appendingPathComponent("scripts/check_imports.swift")
  149. if FileManager.default.fileExists(atPath: script.path) {
  150. break
  151. }
  152. url = url.deletingLastPathComponent()
  153. }
  154. let repoURL = url
  155. guard let contents = try? FileManager.default.contentsOfDirectory(at: repoURL,
  156. includingPropertiesForKeys: nil,
  157. options: [.skipsHiddenFiles])
  158. else {
  159. logger.log("Failed to get repo contents \(repoURL)")
  160. return 1
  161. }
  162. for rootURL in contents {
  163. if !rootURL.hasDirectoryPath {
  164. continue
  165. }
  166. let enumerator = FileManager.default.enumerator(atPath: rootURL.path)
  167. whileLoop: while let file = enumerator?.nextObject() as? String {
  168. if let fType = enumerator?.fileAttributes?[FileAttributeKey.type] as? FileAttributeType,
  169. fType == .typeRegular {
  170. if file.starts(with: ".") {
  171. continue
  172. }
  173. if !(file.hasSuffix(".h") ||
  174. file.hasSuffix(".m") ||
  175. file.hasSuffix(".mm") ||
  176. file.hasSuffix(".c")) {
  177. continue
  178. }
  179. let fullTransformPath = rootURL.path + "/" + file
  180. for dirPattern in skipDirPatterns {
  181. if fullTransformPath.range(of: dirPattern) != nil {
  182. continue whileLoop
  183. }
  184. }
  185. checkFile(fullTransformPath, logger: logger, inRepo: repoURL)
  186. }
  187. }
  188. }
  189. return logger.foundError ? 1 : 0
  190. }
  191. exit(main())