FSTRemoteEventTests.mm 38 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826
  1. /*
  2. * Copyright 2017 Google
  3. *
  4. * Licensed under the Apache License, Version 2.0 (the "License");
  5. * you may not use this file except in compliance with the License.
  6. * You may obtain a copy of the License at
  7. *
  8. * http://www.apache.org/licenses/LICENSE-2.0
  9. *
  10. * Unless required by applicable law or agreed to in writing, software
  11. * distributed under the License is distributed on an "AS IS" BASIS,
  12. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13. * See the License for the specific language governing permissions and
  14. * limitations under the License.
  15. */
  16. #import <XCTest/XCTest.h>
  17. #include <memory>
  18. #include <unordered_map>
  19. #include <utility>
  20. #include <vector>
  21. #import "Firestore/Source/Core/FSTQuery.h"
  22. #import "Firestore/Source/Local/FSTQueryData.h"
  23. #import "Firestore/Source/Model/FSTDocument.h"
  24. #include "Firestore/core/src/firebase/firestore/model/document_key.h"
  25. #include "Firestore/core/src/firebase/firestore/model/types.h"
  26. #include "Firestore/core/src/firebase/firestore/remote/existence_filter.h"
  27. #include "Firestore/core/src/firebase/firestore/remote/remote_event.h"
  28. #include "Firestore/core/src/firebase/firestore/remote/watch_change.h"
  29. #import "Firestore/Example/Tests/Util/FSTHelpers.h"
  30. #include "Firestore/core/test/firebase/firestore/testutil/testutil.h"
  31. #include "absl/memory/memory.h"
  32. namespace testutil = firebase::firestore::testutil;
  33. using firebase::firestore::model::DocumentKey;
  34. using firebase::firestore::model::DocumentKeySet;
  35. using firebase::firestore::model::DocumentState;
  36. using firebase::firestore::model::SnapshotVersion;
  37. using firebase::firestore::model::TargetId;
  38. using firebase::firestore::remote::DocumentWatchChange;
  39. using firebase::firestore::remote::ExistenceFilter;
  40. using firebase::firestore::remote::ExistenceFilterWatchChange;
  41. using firebase::firestore::remote::RemoteEvent;
  42. using firebase::firestore::remote::TargetChange;
  43. using firebase::firestore::remote::TestTargetMetadataProvider;
  44. using firebase::firestore::remote::WatchChange;
  45. using firebase::firestore::remote::WatchChangeAggregator;
  46. using firebase::firestore::remote::WatchTargetChange;
  47. using firebase::firestore::remote::WatchTargetChangeState;
  48. using firebase::firestore::testutil::VectorOfUniquePtrs;
  49. using firebase::firestore::util::MakeString;
  50. using firebase::firestore::util::Status;
  51. NS_ASSUME_NONNULL_BEGIN
  52. namespace {
  53. template <typename... Elems>
  54. std::vector<std::unique_ptr<WatchChange>> Changes(Elems... elems) {
  55. return VectorOfUniquePtrs<WatchChange>(std::move(elems)...);
  56. }
  57. // These helpers work around the fact that `make_unique` cannot deduce the
  58. // desired type (`vector<TargetId>` in this case) from an initialization list
  59. // (e.g., `{1,2}`).
  60. std::unique_ptr<DocumentWatchChange> MakeDocChange(std::vector<TargetId> updated,
  61. std::vector<TargetId> removed,
  62. DocumentKey key,
  63. FSTMaybeDocument *doc) {
  64. return absl::make_unique<DocumentWatchChange>(std::move(updated), std::move(removed),
  65. std::move(key), doc);
  66. }
  67. std::unique_ptr<WatchTargetChange> MakeTargetChange(WatchTargetChangeState state,
  68. std::vector<TargetId> target_ids) {
  69. return absl::make_unique<WatchTargetChange>(state, std::move(target_ids));
  70. }
  71. std::unique_ptr<WatchTargetChange> MakeTargetChange(WatchTargetChangeState state,
  72. std::vector<TargetId> target_ids,
  73. NSData *token) {
  74. return absl::make_unique<WatchTargetChange>(state, std::move(target_ids), token);
  75. }
  76. } // namespace
  77. @interface FSTRemoteEventTests : XCTestCase
  78. @end
  79. @implementation FSTRemoteEventTests {
  80. NSData *_resumeToken1;
  81. TestTargetMetadataProvider _targetMetadataProvider;
  82. std::unordered_map<TargetId, int> _noOutstandingResponses;
  83. }
  84. - (void)setUp {
  85. _resumeToken1 = [@"resume1" dataUsingEncoding:NSUTF8StringEncoding];
  86. }
  87. /**
  88. * Creates a map with query data for the provided target IDs. All targets are considered active
  89. * and query a collection named "coll".
  90. */
  91. - (std::unordered_map<TargetId, FSTQueryData *>)queryDataForTargets:
  92. (std::initializer_list<TargetId>)targetIDs {
  93. std::unordered_map<TargetId, FSTQueryData *> targets;
  94. for (TargetId targetID : targetIDs) {
  95. FSTQuery *query = FSTTestQuery("coll");
  96. targets[targetID] = [[FSTQueryData alloc] initWithQuery:query
  97. targetID:targetID
  98. listenSequenceNumber:0
  99. purpose:FSTQueryPurposeListen];
  100. }
  101. return targets;
  102. }
  103. /**
  104. * Creates a map with query data for the provided target IDs. All targets are marked as limbo
  105. * queries for the document at "coll/limbo".
  106. */
  107. - (std::unordered_map<TargetId, FSTQueryData *>)queryDataForLimboTargets:
  108. (std::initializer_list<TargetId>)targetIDs {
  109. std::unordered_map<TargetId, FSTQueryData *> targets;
  110. for (TargetId targetID : targetIDs) {
  111. FSTQuery *query = FSTTestQuery("coll/limbo");
  112. targets[targetID] = [[FSTQueryData alloc] initWithQuery:query
  113. targetID:targetID
  114. listenSequenceNumber:0
  115. purpose:FSTQueryPurposeLimboResolution];
  116. }
  117. return targets;
  118. }
  119. /**
  120. * Creates an aggregator initialized with the set of provided `WatchChange`s. Tests can add further
  121. * changes via `HandleDocumentChange`, `HandleTargetChange` and `HandleExistenceFilterChange`.
  122. *
  123. * @param targetMap A map of query data for all active targets. The map must include an entry for
  124. * every target referenced by any of the watch changes.
  125. * @param outstandingResponses The number of outstanding ACKs a target has to receive before it is
  126. * considered active, or `_noOutstandingResponses` if all targets are already active.
  127. * @param existingKeys The set of documents that are considered synced with the test targets as
  128. * part of a previous listen. To modify this set during test execution, invoke
  129. * `_targetMetadataProvider.SetSyncedKeys()`.
  130. * @param watchChanges The watch changes to apply before returning the aggregator. Supported
  131. * changes are `DocumentWatchChange` and `WatchTargetChange`.
  132. */
  133. - (WatchChangeAggregator)
  134. aggregatorWithTargetMap:(const std::unordered_map<TargetId, FSTQueryData *> &)targetMap
  135. outstandingResponses:(const std::unordered_map<TargetId, int> &)outstandingResponses
  136. existingKeys:(DocumentKeySet)existingKeys
  137. changes:(const std::vector<std::unique_ptr<WatchChange>> &)watchChanges {
  138. WatchChangeAggregator aggregator{&_targetMetadataProvider};
  139. std::vector<TargetId> targetIDs;
  140. for (const auto &kv : targetMap) {
  141. TargetId targetID = kv.first;
  142. FSTQueryData *queryData = kv.second;
  143. targetIDs.push_back(targetID);
  144. _targetMetadataProvider.SetSyncedKeys(existingKeys, queryData);
  145. };
  146. for (const auto &kv : outstandingResponses) {
  147. TargetId targetID = kv.first;
  148. int count = kv.second;
  149. for (int i = 0; i < count; ++i) {
  150. aggregator.RecordPendingTargetRequest(targetID);
  151. }
  152. }
  153. for (const std::unique_ptr<WatchChange> &change : watchChanges) {
  154. switch (change->type()) {
  155. case WatchChange::Type::Document: {
  156. aggregator.HandleDocumentChange(*static_cast<const DocumentWatchChange *>(change.get()));
  157. break;
  158. }
  159. case WatchChange::Type::TargetChange: {
  160. aggregator.HandleTargetChange(*static_cast<const WatchTargetChange *>(change.get()));
  161. break;
  162. }
  163. default:
  164. HARD_ASSERT("Encountered unexpected type of WatchChange");
  165. }
  166. }
  167. aggregator.HandleTargetChange(
  168. WatchTargetChange{WatchTargetChangeState::NoChange, targetIDs, _resumeToken1});
  169. return aggregator;
  170. }
  171. /**
  172. * Creates a single remote event that includes target changes for all provided `WatchChange`s.
  173. *
  174. * @param snapshotVersion The version at which to create the remote event. This corresponds to the
  175. * snapshot version provided by the NO_CHANGE event.
  176. * @param targetMap A map of query data for all active targets. The map must include an entry for
  177. * every target referenced by any of the watch changes.
  178. * @param outstandingResponses The number of outstanding ACKs a target has to receive before it is
  179. * considered active, or `_noOutstandingResponses` if all targets are already active.
  180. * @param existingKeys The set of documents that are considered synced with the test targets as
  181. * part of a previous listen.
  182. * @param watchChanges The watch changes to apply before creating the remote event. Supported
  183. * changes are `DocumentWatchChange` and `WatchTargetChange`.
  184. */
  185. - (RemoteEvent)
  186. remoteEventAtSnapshotVersion:(FSTTestSnapshotVersion)snapshotVersion
  187. targetMap:(std::unordered_map<TargetId, FSTQueryData *>)targetMap
  188. outstandingResponses:(const std::unordered_map<TargetId, int> &)outstandingResponses
  189. existingKeys:(DocumentKeySet)existingKeys
  190. changes:(const std::vector<std::unique_ptr<WatchChange>> &)watchChanges {
  191. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  192. outstandingResponses:outstandingResponses
  193. existingKeys:existingKeys
  194. changes:watchChanges];
  195. return aggregator.CreateRemoteEvent(testutil::Version(snapshotVersion));
  196. }
  197. - (void)testWillAccumulateDocumentAddedAndRemovedEvents {
  198. // The target map that contains an entry for every target in this test. If a target ID is
  199. // omitted, the target is considered inactive and `TestTargetMetadataProvider` will fail on
  200. // access.
  201. std::unordered_map<TargetId, FSTQueryData *> targetMap{
  202. [self queryDataForTargets:{1, 2, 3, 4, 5, 6}]};
  203. FSTDocument *existingDoc = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  204. auto change1 = MakeDocChange({1, 2, 3}, {4, 5, 6}, existingDoc.key, existingDoc);
  205. FSTDocument *newDoc = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  206. auto change2 = MakeDocChange({1, 4}, {2, 6}, newDoc.key, newDoc);
  207. // Create a remote event that includes both `change1` and `change2` as well as a NO_CHANGE event
  208. // with the default resume token (`_resumeToken1`).
  209. // As `existingDoc` is provided as an existing key, any updates to this document will be treated
  210. // as modifications rather than adds.
  211. RemoteEvent event =
  212. [self remoteEventAtSnapshotVersion:3
  213. targetMap:targetMap
  214. outstandingResponses:_noOutstandingResponses
  215. existingKeys:DocumentKeySet{existingDoc.key}
  216. changes:Changes(std::move(change1), std::move(change2))];
  217. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  218. XCTAssertEqual(event.document_updates().size(), 2);
  219. XCTAssertEqualObjects(event.document_updates().at(existingDoc.key), existingDoc);
  220. XCTAssertEqualObjects(event.document_updates().at(newDoc.key), newDoc);
  221. // 'change1' and 'change2' affect six different targets
  222. XCTAssertEqual(event.target_changes().size(), 6);
  223. TargetChange targetChange1{_resumeToken1, false, DocumentKeySet{newDoc.key},
  224. DocumentKeySet{existingDoc.key}, DocumentKeySet{}};
  225. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  226. TargetChange targetChange2{_resumeToken1, false, DocumentKeySet{},
  227. DocumentKeySet{existingDoc.key}, DocumentKeySet{}};
  228. XCTAssertTrue(event.target_changes().at(2) == targetChange2);
  229. TargetChange targetChange3{_resumeToken1, false, DocumentKeySet{},
  230. DocumentKeySet{existingDoc.key}, DocumentKeySet{}};
  231. XCTAssertTrue(event.target_changes().at(3) == targetChange3);
  232. TargetChange targetChange4{_resumeToken1, false, DocumentKeySet{newDoc.key}, DocumentKeySet{},
  233. DocumentKeySet{existingDoc.key}};
  234. XCTAssertTrue(event.target_changes().at(4) == targetChange4);
  235. TargetChange targetChange5{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{},
  236. DocumentKeySet{existingDoc.key}};
  237. XCTAssertTrue(event.target_changes().at(5) == targetChange5);
  238. TargetChange targetChange6{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{},
  239. DocumentKeySet{existingDoc.key}};
  240. XCTAssertTrue(event.target_changes().at(6) == targetChange6);
  241. }
  242. - (void)testWillIgnoreEventsForPendingTargets {
  243. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  244. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  245. auto change1 = MakeDocChange({1}, {}, doc1.key, doc1);
  246. auto change2 = MakeTargetChange(WatchTargetChangeState::Removed, {1});
  247. auto change3 = MakeTargetChange(WatchTargetChangeState::Added, {1});
  248. FSTDocument *doc2 = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  249. auto change4 = MakeDocChange({1}, {}, doc2.key, doc2);
  250. // We're waiting for the unwatch and watch ack
  251. std::unordered_map<TargetId, int> outstandingResponses{{1, 2}};
  252. RemoteEvent event =
  253. [self remoteEventAtSnapshotVersion:3
  254. targetMap:targetMap
  255. outstandingResponses:outstandingResponses
  256. existingKeys:DocumentKeySet {}
  257. changes:Changes(std::move(change1), std::move(change2),
  258. std::move(change3), std::move(change4))];
  259. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  260. // doc1 is ignored because it was part of an inactive target, but doc2 is in the changes
  261. // because it become active.
  262. XCTAssertEqual(event.document_updates().size(), 1);
  263. XCTAssertEqualObjects(event.document_updates().at(doc2.key), doc2);
  264. XCTAssertEqual(event.target_changes().size(), 1);
  265. }
  266. - (void)testWillIgnoreEventsForRemovedTargets {
  267. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{}]};
  268. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  269. auto change1 = MakeDocChange({1}, {}, doc1.key, doc1);
  270. auto change2 = MakeTargetChange(WatchTargetChangeState::Removed, {1});
  271. // We're waiting for the unwatch ack
  272. std::unordered_map<TargetId, int> outstandingResponses{{1, 1}};
  273. RemoteEvent event =
  274. [self remoteEventAtSnapshotVersion:3
  275. targetMap:targetMap
  276. outstandingResponses:outstandingResponses
  277. existingKeys:DocumentKeySet {}
  278. changes:Changes(std::move(change1), std::move(change2))];
  279. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  280. // doc1 is ignored because it was part of an inactive target
  281. XCTAssertEqual(event.document_updates().size(), 0);
  282. // Target 1 is ignored because it was removed
  283. XCTAssertEqual(event.target_changes().size(), 0);
  284. }
  285. - (void)testWillKeepResetMappingEvenWithUpdates {
  286. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  287. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  288. auto change1 = MakeDocChange({1}, {}, doc1.key, doc1);
  289. // Reset stream, ignoring doc1
  290. auto change2 = MakeTargetChange(WatchTargetChangeState::Reset, {1});
  291. // Add doc2, doc3
  292. FSTDocument *doc2 = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  293. auto change3 = MakeDocChange({1}, {}, doc2.key, doc2);
  294. FSTDocument *doc3 = FSTTestDoc("docs/3", 3, @{@"value" : @3}, DocumentState::kSynced);
  295. auto change4 = MakeDocChange({1}, {}, doc3.key, doc3);
  296. // Remove doc2 again, should not show up in reset mapping
  297. auto change5 = MakeDocChange({}, {1}, doc2.key, doc2);
  298. RemoteEvent event =
  299. [self remoteEventAtSnapshotVersion:3
  300. targetMap:targetMap
  301. outstandingResponses:_noOutstandingResponses
  302. existingKeys:DocumentKeySet{doc1.key}
  303. changes:Changes(std::move(change1), std::move(change2),
  304. std::move(change3), std::move(change4),
  305. std::move(change5))];
  306. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  307. XCTAssertEqual(event.document_updates().size(), 3);
  308. XCTAssertEqualObjects(event.document_updates().at(doc1.key), doc1);
  309. XCTAssertEqualObjects(event.document_updates().at(doc2.key), doc2);
  310. XCTAssertEqualObjects(event.document_updates().at(doc3.key), doc3);
  311. XCTAssertEqual(event.target_changes().size(), 1);
  312. // Only doc3 is part of the new mapping
  313. TargetChange expectedChange{_resumeToken1, false, DocumentKeySet{doc3.key}, DocumentKeySet{},
  314. DocumentKeySet{doc1.key}};
  315. XCTAssertTrue(event.target_changes().at(1) == expectedChange);
  316. }
  317. - (void)testWillHandleSingleReset {
  318. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  319. // Reset target
  320. WatchTargetChange change{WatchTargetChangeState::Reset, {1}};
  321. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  322. outstandingResponses:_noOutstandingResponses
  323. existingKeys:DocumentKeySet {}
  324. changes:{}];
  325. aggregator.HandleTargetChange(change);
  326. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  327. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  328. XCTAssertEqual(event.document_updates().size(), 0);
  329. XCTAssertEqual(event.target_changes().size(), 1);
  330. // Reset mapping is empty
  331. TargetChange expectedChange{
  332. [NSData data], false, DocumentKeySet{}, DocumentKeySet{}, DocumentKeySet{}};
  333. XCTAssertTrue(event.target_changes().at(1) == expectedChange);
  334. }
  335. - (void)testWillHandleTargetAddAndRemovalInSameBatch {
  336. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1, 2}]};
  337. FSTDocument *doc1a = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  338. auto change1 = MakeDocChange({1}, {2}, doc1a.key, doc1a);
  339. FSTDocument *doc1b = FSTTestDoc("docs/1", 1, @{@"value" : @2}, DocumentState::kSynced);
  340. auto change2 = MakeDocChange({2}, {1}, doc1b.key, doc1b);
  341. RemoteEvent event =
  342. [self remoteEventAtSnapshotVersion:3
  343. targetMap:targetMap
  344. outstandingResponses:_noOutstandingResponses
  345. existingKeys:DocumentKeySet{doc1a.key}
  346. changes:Changes(std::move(change1), std::move(change2))];
  347. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  348. XCTAssertEqual(event.document_updates().size(), 1);
  349. XCTAssertEqualObjects(event.document_updates().at(doc1b.key), doc1b);
  350. XCTAssertEqual(event.target_changes().size(), 2);
  351. TargetChange targetChange1{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{},
  352. DocumentKeySet{doc1b.key}};
  353. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  354. TargetChange targetChange2{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{doc1b.key},
  355. DocumentKeySet{}};
  356. XCTAssertTrue(event.target_changes().at(2) == targetChange2);
  357. }
  358. - (void)testTargetCurrentChangeWillMarkTheTargetCurrent {
  359. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  360. auto change = MakeTargetChange(WatchTargetChangeState::Current, {1}, _resumeToken1);
  361. RemoteEvent event = [self remoteEventAtSnapshotVersion:3
  362. targetMap:targetMap
  363. outstandingResponses:_noOutstandingResponses
  364. existingKeys:DocumentKeySet {}
  365. changes:Changes(std::move(change))];
  366. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  367. XCTAssertEqual(event.document_updates().size(), 0);
  368. XCTAssertEqual(event.target_changes().size(), 1);
  369. TargetChange targetChange1{_resumeToken1, true, DocumentKeySet{}, DocumentKeySet{},
  370. DocumentKeySet{}};
  371. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  372. }
  373. - (void)testTargetAddedChangeWillResetPreviousState {
  374. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1, 3}]};
  375. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  376. auto change1 = MakeDocChange({1, 3}, {2}, doc1.key, doc1);
  377. auto change2 = MakeTargetChange(WatchTargetChangeState::Current, {1, 2, 3}, _resumeToken1);
  378. auto change3 = MakeTargetChange(WatchTargetChangeState::Removed, {1});
  379. auto change4 = MakeTargetChange(WatchTargetChangeState::Removed, {2});
  380. auto change5 = MakeTargetChange(WatchTargetChangeState::Added, {1});
  381. FSTDocument *doc2 = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  382. auto change6 = MakeDocChange({1}, {3}, doc2.key, doc2);
  383. std::unordered_map<TargetId, int> outstandingResponses{{1, 2}, {2, 1}};
  384. RemoteEvent event =
  385. [self remoteEventAtSnapshotVersion:3
  386. targetMap:targetMap
  387. outstandingResponses:outstandingResponses
  388. existingKeys:DocumentKeySet{doc2.key}
  389. changes:Changes(std::move(change1), std::move(change2),
  390. std::move(change3), std::move(change4),
  391. std::move(change5), std::move(change6))];
  392. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  393. XCTAssertEqual(event.document_updates().size(), 2);
  394. XCTAssertEqualObjects(event.document_updates().at(doc1.key), doc1);
  395. XCTAssertEqualObjects(event.document_updates().at(doc2.key), doc2);
  396. // target 1 and 3 are affected (1 because of re-add), target 2 is not because of remove
  397. XCTAssertEqual(event.target_changes().size(), 2);
  398. // doc1 was before the remove, so it does not show up in the mapping.
  399. // Current was before the remove.
  400. TargetChange targetChange1{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{doc2.key},
  401. DocumentKeySet{}};
  402. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  403. // Doc1 was before the remove
  404. // Current was before the remove
  405. TargetChange targetChange3{_resumeToken1, true, DocumentKeySet{doc1.key}, DocumentKeySet{},
  406. DocumentKeySet{doc2.key}};
  407. XCTAssertTrue(event.target_changes().at(3) == targetChange3);
  408. }
  409. - (void)testNoChangeWillStillMarkTheAffectedTargets {
  410. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  411. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  412. outstandingResponses:_noOutstandingResponses
  413. existingKeys:DocumentKeySet {}
  414. changes:{}];
  415. WatchTargetChange change{WatchTargetChangeState::NoChange, {1}, _resumeToken1};
  416. aggregator.HandleTargetChange(change);
  417. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  418. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  419. XCTAssertEqual(event.document_updates().size(), 0);
  420. XCTAssertEqual(event.target_changes().size(), 1);
  421. TargetChange targetChange{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{},
  422. DocumentKeySet{}};
  423. XCTAssertTrue(event.target_changes().at(1) == targetChange);
  424. }
  425. - (void)testExistenceFilterMismatchClearsTarget {
  426. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1, 2}]};
  427. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  428. auto change1 = MakeDocChange({1}, {}, doc1.key, doc1);
  429. FSTDocument *doc2 = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  430. auto change2 = MakeDocChange({1}, {}, doc2.key, doc2);
  431. auto change3 = MakeTargetChange(WatchTargetChangeState::Current, {1}, _resumeToken1);
  432. WatchChangeAggregator aggregator = [self
  433. aggregatorWithTargetMap:targetMap
  434. outstandingResponses:_noOutstandingResponses
  435. existingKeys:DocumentKeySet{doc1.key, doc2.key}
  436. changes:Changes(std::move(change1), std::move(change2), std::move(change3))];
  437. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  438. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  439. XCTAssertEqual(event.document_updates().size(), 2);
  440. XCTAssertEqualObjects(event.document_updates().at(doc1.key), doc1);
  441. XCTAssertEqualObjects(event.document_updates().at(doc2.key), doc2);
  442. XCTAssertEqual(event.target_changes().size(), 2);
  443. TargetChange targetChange1{_resumeToken1, true, DocumentKeySet{},
  444. DocumentKeySet{doc1.key, doc2.key}, DocumentKeySet{}};
  445. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  446. TargetChange targetChange2{_resumeToken1, false, DocumentKeySet{}, DocumentKeySet{},
  447. DocumentKeySet{}};
  448. XCTAssertTrue(event.target_changes().at(2) == targetChange2);
  449. // The existence filter mismatch will remove the document from target 1,
  450. // but not synthesize a document delete.
  451. ExistenceFilterWatchChange change4{ExistenceFilter{1}, 1};
  452. aggregator.HandleExistenceFilter(change4);
  453. event = aggregator.CreateRemoteEvent(testutil::Version(4));
  454. TargetChange targetChange3{
  455. [NSData data], false, DocumentKeySet{}, DocumentKeySet{}, DocumentKeySet{doc1.key, doc2.key}};
  456. XCTAssertTrue(event.target_changes().at(1) == targetChange3);
  457. XCTAssertEqual(event.target_changes().size(), 1);
  458. XCTAssertEqual(event.target_mismatches().size(), 1);
  459. XCTAssertEqual(event.document_updates().size(), 0);
  460. }
  461. - (void)testExistenceFilterMismatchRemovesCurrentChanges {
  462. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  463. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  464. outstandingResponses:_noOutstandingResponses
  465. existingKeys:DocumentKeySet {}
  466. changes:{}];
  467. WatchTargetChange markCurrent{WatchTargetChangeState::Current, {1}, _resumeToken1};
  468. aggregator.HandleTargetChange(markCurrent);
  469. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  470. DocumentWatchChange addDoc{{1}, {}, doc1.key, doc1};
  471. aggregator.HandleDocumentChange(addDoc);
  472. // The existence filter mismatch will remove the document from target 1, but not synthesize a
  473. // document delete.
  474. ExistenceFilterWatchChange existenceFilter{ExistenceFilter{0}, 1};
  475. aggregator.HandleExistenceFilter(existenceFilter);
  476. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  477. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  478. XCTAssertEqual(event.document_updates().size(), 1);
  479. XCTAssertEqual(event.target_mismatches().size(), 1);
  480. XCTAssertEqualObjects(event.document_updates().at(doc1.key), doc1);
  481. XCTAssertEqual(event.target_changes().size(), 1);
  482. TargetChange targetChange1{
  483. [NSData data], false, DocumentKeySet{}, DocumentKeySet{}, DocumentKeySet{}};
  484. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  485. }
  486. - (void)testDocumentUpdate {
  487. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  488. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"value" : @1}, DocumentState::kSynced);
  489. auto change1 = MakeDocChange({1}, {}, doc1.key, doc1);
  490. FSTDocument *doc2 = FSTTestDoc("docs/2", 2, @{@"value" : @2}, DocumentState::kSynced);
  491. auto change2 = MakeDocChange({1}, {}, doc2.key, doc2);
  492. WatchChangeAggregator aggregator =
  493. [self aggregatorWithTargetMap:targetMap
  494. outstandingResponses:_noOutstandingResponses
  495. existingKeys:DocumentKeySet {}
  496. changes:Changes(std::move(change1), std::move(change2))];
  497. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  498. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  499. XCTAssertEqual(event.document_updates().size(), 2);
  500. XCTAssertEqualObjects(event.document_updates().at(doc1.key), doc1);
  501. XCTAssertEqualObjects(event.document_updates().at(doc2.key), doc2);
  502. _targetMetadataProvider.SetSyncedKeys(DocumentKeySet{doc1.key, doc2.key}, targetMap[1]);
  503. FSTDeletedDocument *deletedDoc1 = [FSTDeletedDocument documentWithKey:doc1.key
  504. version:testutil::Version(3)
  505. hasCommittedMutations:NO];
  506. DocumentWatchChange change3{{}, {1}, deletedDoc1.key, deletedDoc1};
  507. aggregator.HandleDocumentChange(change3);
  508. FSTDocument *updatedDoc2 = FSTTestDoc("docs/2", 3, @{@"value" : @2}, DocumentState::kSynced);
  509. DocumentWatchChange change4{{1}, {}, updatedDoc2.key, updatedDoc2};
  510. aggregator.HandleDocumentChange(change4);
  511. FSTDocument *doc3 = FSTTestDoc("docs/3", 3, @{@"value" : @3}, DocumentState::kSynced);
  512. DocumentWatchChange change5{{1}, {}, doc3.key, doc3};
  513. aggregator.HandleDocumentChange(change5);
  514. event = aggregator.CreateRemoteEvent(testutil::Version(3));
  515. XCTAssertEqual(event.snapshot_version(), testutil::Version(3));
  516. XCTAssertEqual(event.document_updates().size(), 3);
  517. // doc1 is replaced
  518. XCTAssertEqualObjects(event.document_updates().at(doc1.key), deletedDoc1);
  519. // doc2 is updated
  520. XCTAssertEqualObjects(event.document_updates().at(doc2.key), updatedDoc2);
  521. // doc3 is new
  522. XCTAssertEqualObjects(event.document_updates().at(doc3.key), doc3);
  523. // Target is unchanged
  524. XCTAssertEqual(event.target_changes().size(), 1);
  525. TargetChange targetChange1{_resumeToken1, false, DocumentKeySet{doc3.key},
  526. DocumentKeySet{updatedDoc2.key}, DocumentKeySet{deletedDoc1.key}};
  527. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  528. }
  529. - (void)testResumeTokensHandledPerTarget {
  530. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1, 2}]};
  531. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  532. outstandingResponses:_noOutstandingResponses
  533. existingKeys:DocumentKeySet {}
  534. changes:{}];
  535. WatchTargetChange change1{WatchTargetChangeState::Current, {1}, _resumeToken1};
  536. aggregator.HandleTargetChange(change1);
  537. NSData *resumeToken2 = [@"resume2" dataUsingEncoding:NSUTF8StringEncoding];
  538. WatchTargetChange change2{WatchTargetChangeState::Current, {2}, resumeToken2};
  539. aggregator.HandleTargetChange(change2);
  540. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  541. XCTAssertEqual(event.target_changes().size(), 2);
  542. TargetChange targetChange1{_resumeToken1, true, DocumentKeySet{}, DocumentKeySet{},
  543. DocumentKeySet{}};
  544. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  545. TargetChange targetChange2{resumeToken2, true, DocumentKeySet{}, DocumentKeySet{},
  546. DocumentKeySet{}};
  547. XCTAssertTrue(event.target_changes().at(2) == targetChange2);
  548. }
  549. - (void)testLastResumeTokenWins {
  550. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1, 2}]};
  551. WatchChangeAggregator aggregator = [self aggregatorWithTargetMap:targetMap
  552. outstandingResponses:_noOutstandingResponses
  553. existingKeys:DocumentKeySet {}
  554. changes:{}];
  555. WatchTargetChange change1{WatchTargetChangeState::Current, {1}, _resumeToken1};
  556. aggregator.HandleTargetChange(change1);
  557. NSData *resumeToken2 = [@"resume2" dataUsingEncoding:NSUTF8StringEncoding];
  558. WatchTargetChange change2{WatchTargetChangeState::NoChange, {1}, resumeToken2};
  559. aggregator.HandleTargetChange(change2);
  560. NSData *resumeToken3 = [@"resume3" dataUsingEncoding:NSUTF8StringEncoding];
  561. WatchTargetChange change3{WatchTargetChangeState::NoChange, {2}, resumeToken3};
  562. aggregator.HandleTargetChange(change3);
  563. RemoteEvent event = aggregator.CreateRemoteEvent(testutil::Version(3));
  564. XCTAssertEqual(event.target_changes().size(), 2);
  565. TargetChange targetChange1{resumeToken2, true, DocumentKeySet{}, DocumentKeySet{},
  566. DocumentKeySet{}};
  567. XCTAssertTrue(event.target_changes().at(1) == targetChange1);
  568. TargetChange targetChange2{resumeToken3, false, DocumentKeySet{}, DocumentKeySet{},
  569. DocumentKeySet{}};
  570. XCTAssertTrue(event.target_changes().at(2) == targetChange2);
  571. }
  572. - (void)testSynthesizeDeletes {
  573. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForLimboTargets:{1}]};
  574. DocumentKey limboKey = testutil::Key("coll/limbo");
  575. auto resolveLimboTarget = MakeTargetChange(WatchTargetChangeState::Current, {1});
  576. RemoteEvent event = [self remoteEventAtSnapshotVersion:3
  577. targetMap:targetMap
  578. outstandingResponses:_noOutstandingResponses
  579. existingKeys:DocumentKeySet {}
  580. changes:Changes(std::move(resolveLimboTarget))];
  581. FSTDeletedDocument *expected = [FSTDeletedDocument documentWithKey:limboKey
  582. version:event.snapshot_version()
  583. hasCommittedMutations:NO];
  584. XCTAssertEqualObjects(event.document_updates().at(limboKey), expected);
  585. XCTAssertTrue(event.limbo_document_changes().contains(limboKey));
  586. }
  587. - (void)testDoesntSynthesizeDeletesForWrongState {
  588. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{1}]};
  589. auto wrongState = MakeTargetChange(WatchTargetChangeState::NoChange, {1});
  590. RemoteEvent event = [self remoteEventAtSnapshotVersion:3
  591. targetMap:targetMap
  592. outstandingResponses:_noOutstandingResponses
  593. existingKeys:DocumentKeySet {}
  594. changes:Changes(std::move(wrongState))];
  595. XCTAssertEqual(event.document_updates().size(), 0);
  596. XCTAssertEqual(event.limbo_document_changes().size(), 0);
  597. }
  598. - (void)testDoesntSynthesizeDeletesForExistingDoc {
  599. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForTargets:{3}]};
  600. auto hasDocument = MakeTargetChange(WatchTargetChangeState::Current, {3});
  601. RemoteEvent event =
  602. [self remoteEventAtSnapshotVersion:3
  603. targetMap:targetMap
  604. outstandingResponses:_noOutstandingResponses
  605. existingKeys:DocumentKeySet{FSTTestDocKey(@"coll/limbo")}
  606. changes:Changes(std::move(hasDocument))];
  607. XCTAssertEqual(event.document_updates().size(), 0);
  608. XCTAssertEqual(event.limbo_document_changes().size(), 0);
  609. }
  610. - (void)testSeparatesDocumentUpdates {
  611. std::unordered_map<TargetId, FSTQueryData *> targetMap{[self queryDataForLimboTargets:{1}]};
  612. FSTDocument *newDoc = FSTTestDoc("docs/new", 1, @{@"key" : @"value"}, DocumentState::kSynced);
  613. auto newDocChange = MakeDocChange({1}, {}, newDoc.key, newDoc);
  614. FSTDocument *existingDoc =
  615. FSTTestDoc("docs/existing", 1, @{@"some" : @"data"}, DocumentState::kSynced);
  616. auto existingDocChange = MakeDocChange({1}, {}, existingDoc.key, existingDoc);
  617. FSTDeletedDocument *deletedDoc = FSTTestDeletedDoc("docs/deleted", 1, NO);
  618. auto deletedDocChange = MakeDocChange({}, {1}, deletedDoc.key, deletedDoc);
  619. FSTDeletedDocument *missingDoc = FSTTestDeletedDoc("docs/missing", 1, NO);
  620. auto missingDocChange = MakeDocChange({}, {1}, missingDoc.key, missingDoc);
  621. RemoteEvent event = [self
  622. remoteEventAtSnapshotVersion:3
  623. targetMap:targetMap
  624. outstandingResponses:_noOutstandingResponses
  625. existingKeys:DocumentKeySet{existingDoc.key, deletedDoc.key}
  626. changes:Changes(std::move(newDocChange), std::move(existingDocChange),
  627. std::move(deletedDocChange),
  628. std::move(missingDocChange))];
  629. TargetChange targetChange2{_resumeToken1, false, DocumentKeySet{newDoc.key},
  630. DocumentKeySet{existingDoc.key}, DocumentKeySet{deletedDoc.key}};
  631. XCTAssertTrue(event.target_changes().at(1) == targetChange2);
  632. }
  633. - (void)testTracksLimboDocuments {
  634. std::unordered_map<TargetId, FSTQueryData *> targetMap = [self queryDataForTargets:{1}];
  635. auto additionalTargets = [self queryDataForLimboTargets:{2}];
  636. targetMap.insert(additionalTargets.begin(), additionalTargets.end());
  637. // Add 3 docs: 1 is limbo and non-limbo, 2 is limbo-only, 3 is non-limbo
  638. FSTDocument *doc1 = FSTTestDoc("docs/1", 1, @{@"key" : @"value"}, DocumentState::kSynced);
  639. FSTDocument *doc2 = FSTTestDoc("docs/2", 1, @{@"key" : @"value"}, DocumentState::kSynced);
  640. FSTDocument *doc3 = FSTTestDoc("docs/3", 1, @{@"key" : @"value"}, DocumentState::kSynced);
  641. // Target 2 is a limbo target
  642. auto docChange1 = MakeDocChange({1, 2}, {}, doc1.key, doc1);
  643. auto docChange2 = MakeDocChange({2}, {}, doc2.key, doc2);
  644. auto docChange3 = MakeDocChange({1}, {}, doc3.key, doc3);
  645. auto targetsChange = MakeTargetChange(WatchTargetChangeState::Current, {1, 2});
  646. RemoteEvent event =
  647. [self remoteEventAtSnapshotVersion:3
  648. targetMap:targetMap
  649. outstandingResponses:_noOutstandingResponses
  650. existingKeys:DocumentKeySet {}
  651. changes:Changes(std::move(docChange1), std::move(docChange2),
  652. std::move(docChange3), std::move(targetsChange))];
  653. DocumentKeySet limboDocChanges = event.limbo_document_changes();
  654. // Doc1 is in both limbo and non-limbo targets, therefore not tracked as limbo
  655. XCTAssertFalse(limboDocChanges.contains(doc1.key));
  656. // Doc2 is only in the limbo target, so is tracked as a limbo document
  657. XCTAssertTrue(limboDocChanges.contains(doc2.key));
  658. // Doc3 is only in the non-limbo target, therefore not tracked as limbo
  659. XCTAssertFalse(limboDocChanges.contains(doc3.key));
  660. }
  661. @end
  662. NS_ASSUME_NONNULL_END